Repository navigation
feat(transaction-fee-charge-audit): explain offered vs charged transaction fees - #489
Merged
egekoca merged 2 commits intoSep 30, 2026
Merged
Conversation
|
@chainsmt Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #468
Summary
Adds Transaction Fee Charge Audit under
features/transaction-fee-charge-audit/. For one settled Horizon transaction it explains the maximum fee offered versus the fee actually charged, distinguishes classic vs fee-bump envelopes, and attaches ledger/network context — without predicting future inclusion prices.Motivation
Operators often see
max_feeandfee_chargedin Horizon JSON but still misread fee-bump wrappers (outer bid vs inner bid) or silently accept missing fee fields. This tool normalizes those fields, computes an exact stroop difference, and fails loudly when the audit would be incomplete.What this PR does
GET /transactions/{hash}on the selected network and identifies classic vs fee-bump fromenvelope_xdr(fallback:fee_account) vialib/fee-fields.ts.max_feeandfee_chargedas stroop strings and computes the exact difference withBigInt(lib/stroop-difference.ts) — no floats.lib/ledger-context.ts→GET /ledgers/{sequence}for closed time / base fee labels).invalid_fee_data— an explicit incomplete audit with actionable copy, not a guessed difference.Architecture notes
features/transaction-fee-charge-audit/.Acceptance criteria coverage
Out of scope
Test plan
npm run verify:features -- transaction-fee-charge-auditnpm test -- features/transaction-fee-charge-audit(51 tests)invalid_fee_datacopy