Repository navigation
Conversation
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
egekoca
left a comment
There was a problem hiding this comment.
The added test suite is currently red. npm test fails in tests/wallet/freighterAccount.test.ts at polls for account changes when listeners are unavailable because onUpdate receives zero calls. Lint and build pass. Please fix the polling implementation or deterministic timer/async setup so the new fallback behavior is actually proven, then rerun the full test suite.
|
Thanks for the review @egekoca. Fixed the red test: the fallback poll was correct, but
|
30abd2d to
086cb06
Compare
|
Closing: this predates the |
Closes #60
Summary
Test plan