Skip to content

feat(RevyHub): qr-support-stellar-payment-memo-types-in-generat - #105

Merged
egekoca merged 2 commits into
RevenantLabs:mainfrom
Caneryy:feat/issue-66
Sep 30, 2026
Merged

egekoca merged 2 commits into
RevenantLabs:mainfrom
Caneryy:feat/issue-66

Conversation

@Caneryy

@Caneryy Caneryy commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Closes #66

Summary

  • [QR] Support Stellar payment memo types in generated URIs

Test plan

  • Relevant tests pass locally
  • Manual verification on affected UI or API paths

@drips-wave

drips-wave Bot commented Jul 23, 2026

Copy link
Copy Markdown

@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@egekoca egekoca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The production build fails TypeScript validation in lib/stellar/paymentUri.ts because the project target is below ES2020 and the code uses the 0n BigInt literal. npm test and npm run lint pass, but npm run build fails at memoId < 0n. Please use a target-compatible comparison such as BigInt(0), keep the uint64 boundary tests, and rerun all three quality gates from a clean checkout.

@Caneryy

Caneryy commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @egekoca. Fixed the build and refreshed the branch:

  • Replaced the 0n BigInt literal with BigInt(0) in the memo-ID bounds check so it no longer requires an ES2020 target. Kept the uint64 boundary tests (0, max, overflow, non-numeric).
  • Merged latest main and resolved the conflicts by keeping the memo-type feature on top of the new validatePaymentForm/network flow (native XLM omits asset_code, memo_type is always emitted, memo limit is 28 UTF-8 bytes, and network_passphrase follows the network).

All three gates pass from a clean checkout:

  • npm test → 163 passed
  • npm run lint → clean
  • npm run build → succeeds

@egekoca
egekoca merged commit 3c1be31 into RevenantLabs:main Sep 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants