feat(RevyHub): qr-support-stellar-payment-memo-types-in-generat - #105
Conversation
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
egekoca
left a comment
There was a problem hiding this comment.
The production build fails TypeScript validation in lib/stellar/paymentUri.ts because the project target is below ES2020 and the code uses the 0n BigInt literal. npm test and npm run lint pass, but npm run build fails at memoId < 0n. Please use a target-compatible comparison such as BigInt(0), keep the uint64 boundary tests, and rerun all three quality gates from a clean checkout.
|
Thanks @egekoca. Fixed the build and refreshed the branch:
All three gates pass from a clean checkout:
|
fadd650 to
3cb46c5
Compare
Closes #66
Summary
Test plan