Update WebUI styles, Mithril, and build tooling

[zelfroster]

Changes

• webui-src/app/scss/ and generated CSS: restore and regenerate styles.
• webui-src/app/mithril.js: update Mithril to 2.3.8.
• webui-src/make-src/ and webui.pro: add sh compatibility and grouped build output.
• webui-src/package*.json, eslint.config.mjs, and application JavaScript: add ESLint 10 and resolve violations.
• README.md: update contributor commands.

[zelfroster]

@defnax can you test building it on windows once? I have already tested on mac so linux should work fine as well.

cd webui-src
npm run build # <-- this command now, builds css from scss and also builds webui so no need to run any other command other than this.
npm run lint

More details about everything in the README.md file in this PR, so you can give it a read and review it once as well.

[defnax]

I can test tonight, but i use the build.sh or build.bat
Maybe the build scripts needed to be updated?

[zelfroster]

I can test tonight, but i use the build.sh or build.bat Maybe the build scripts needed to be updated?

already updated, also npm run build will also detect your platform and run build.sh/build.bat automatically.

[defnax]

Possible my pr #121 is broken howto fix to not break your changes

[defnax]

i has tested no problems on win, but i saw you removed some used code, the other edits looks ok to me

[defnax]

but you has removed some code why? i see a new bug intruced by you i think

[defnax]

any news? im waiting to update my pr when your is done

[zelfroster]

but you has removed some code why? i see a new bug intruced by you i think

Yes, removed the code since they were not used anywhere.

Also, what's the bug? I saw that you still were missing some scss files which were not committed in your last PR, so I recovered them back from the generated styles.css file with the help of AI. So, the styles should be back, if anything is missing let me know.

[defnax]

You remove this this now has a bug on chats tab in people

[zelfroster]

You remove this this now has a bug on chats tab in people

Your review might still be in pending, I didn't see it.

Also I removed it since this code is practically unused. I added linting for this exact reason. Eslint flagged this as unused code and I removed it.

And what's exactly the bug? can you explain how to reproduce? I can fix it once I am able to understand the issue.

[defnax]

ok now tonight no issue i dont know why

[zelfroster]

ok now tonight no issue i dont know why

Alright, but still if you can describe the issue you were facing so I can verify from my end too.

Also, I need one other person to verify and confirm the build. @jolavillette Can you also build once on different devices if you can?

[defnax]

but one issue i removed from my own pr not critical waiting for api to get merged
RetroShare/libretroshare#350

on master code two places asks for api rsChats/getAvatar

[jolavillette]

Tested on Linux (Debian/Ubuntu, x86_64): npm ci, npm run build and npm run lint all pass, both on Node 24.15.0 and on Node 18.19.1. On Node 18 npm prints EBADENGINE warnings because of the declared engines: >=24, but nothing actually fails.

The generated webui/ contains the same 84 modules as current master, and sass regenerates the committed styles.css byte-for-byte from the SCSS sources, so the styles are indeed back in sync.

I also checked build.sh runs cleanly under dash (/bin/sh on Debian/Ubuntu), which was the main risk in the bash to POSIX rewrite, and the CMake side is unaffected since it only invokes build.sh and needs no Node at all.

[zelfroster]

Thanks @defnax @jolavillette for helping in testing it out 🙏🏼.

I am going to merge this tonight @csoler. Let me know if you have any other thoughts regarding these changes.

[csoler]

I'm fine with it. Thx.