feat: improve title and description in embeds#392
Merged
Conversation
Confidence Score: 4/5Safe to merge; change only affects meta tags injected into page head. Small, well-scoped change. The only rough edge is that pages missing a description frontmatter will emit an empty twitter:description tag rather than omitting it. docs/.vitepress/config/shared.ts — the transformHead description guard. Reviews (1): Last reviewed commit: "feat: improve title and description in e..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, sending a docs link on Discord just always returns RetroAchievement Docs with no description or title or anything.
Now, it will return the full title and description.
A titleTemplate was added, meaning
| RetroAchievements Docsis added to titles.The description pulls from the
description:in the front-matter.