Skip to content

feat: add authorized YouTube audio downloads - #35

Merged
RetricSu merged 2 commits into
developfrom
feature/youtube-dl-local-music
Jun 22, 2026
Merged

RetricSu merged 2 commits into
developfrom
feature/youtube-dl-local-music

Conversation

@RetricSu

Copy link
Copy Markdown
Owner

Summary

  • add a yt-dlp based service for downloading authorized YouTube audio as local MP3 files with embedded metadata and thumbnails
  • add a player-side download entry in the playback info area with URL input and destination folder selection
  • auto-add or resync the download folder after completion so downloaded tracks appear in the library

Verification

  • cargo fmt
  • cargo check
  • cargo test
  • cargo clippy -- -D warnings

Notes

  • Requires yt-dlp and ffmpeg to be installed and available in PATH at runtime.
  • The UI copy frames this as authorized audio downloads only.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a feature to download authorized audio from YouTube using yt-dlp. It adds a new YoutubeDownloadService to handle the download process asynchronously, integrates it with the application state and event loop, and provides a user-friendly download dialog in the playback info panel with support for localization. The code review feedback highlights several important improvements: enhancing cross-platform compatibility on Windows by checking the USERPROFILE environment variable, securing the yt-dlp command execution against option injection using --, simplifying the library path lookup logic to avoid fragile assumptions, and localizing hardcoded English status messages to align with the application's internationalization standards.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/lib/services/youtube_download.rs
Comment thread src/lib/services/youtube_download.rs
Comment thread src/app/core.rs Outdated
Comment thread src/app/core.rs Outdated
Comment thread src/app/core.rs
@RetricSu
RetricSu merged commit 748cc8b into develop Jun 22, 2026
2 checks passed
@RetricSu
RetricSu deleted the feature/youtube-dl-local-music branch June 22, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant