Conversation
|
Download the artifacts for this pull request: |
9712b1d to
bc90df6
Compare
bc90df6 to
78b5ab2
Compare
art0007i
left a comment
art0007i
left a comment
There was a problem hiding this comment.
why harmonyX is netstandard 2.0 in the csproj?
In general, I think we can merge it, but originally I did not get rid of all that, because I was thinking of actually bringing the unity parts of bepinex back, so we have a smaller diff against their upstream. this goes into the opposite direction of ripping out more stuff so we have a bigger diff against upstream, but also at this point I'm fine going either way. Let me know which way you think is better and why.
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
78b5ab2 to
ec86f7f
Compare
because by default HarmonyX builds for .NET Framework as well, which we don't care about and only slows down the cake build. |
Signed-off-by: hazre <mail@haz.re> chore: bump System.Drawing.Common to 10.0.12 Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
ec86f7f to
533e22a
Compare
Signed-off-by: hazre <mail@haz.re>
art0007i
left a comment
art0007i
left a comment
There was a problem hiding this comment.
alright I guess we hard moving away from upstream now
|
Kinda? we still merge stuff from upstream where it makes sense and try to contribute back also when it makes sense. but yeah it's own thing now. |
|
well yeah, as opposed to moving closer to upstream, where we find the minimum changes that are required to achieve what we want. I think this would be ideal, but also this way of just yeeting everything we don't currently need is acceptable |
|
Tbh I would agree here if BepInEx v6 was a constantly updated project with regular frequency of commits but it has been in development standstill for ages now and they still haven't finalized a stable release. But like majority of things coming out of upstream is Unity specific and we don't care for Unity. It's just longer build times, more code to maintain and extra dependencies we don't need. It's all downsides. Our changes are already pretty minimal and easy to merge in upstream changes that relevant to us. |
2 participants
Remove rest of the Unity stuff we don't care about. And update cake build stuff.