Skip to content

refactor: remove deprecated wait() method from DataVolume class #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ema-aka-young wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: remove deprecated wait() method from DataVolume class #2704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3da5955
Remove deprecated wait() method from DataVolume class
ema-aka-young Apr 27, 2026
dc95f11
Merge branch 'main' into cnv-73197-remove-dv-wait
ema-aka-young Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions ocp_resources/datavolume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,23 +259,6 @@ def wait_deleted(self, timeout=TIMEOUT_4MINUTES):
super().wait_deleted(timeout=timeout)
return self.pvc.wait_deleted(timeout=timeout)

def wait(self, timeout=TIMEOUT_10MINUTES, failure_timeout=TIMEOUT_2MINUTES, wait_for_exists_only=False, sleep=1):
warn(
message="DataVolume.wait() is deprecated and will be removed in "
"the next version. Use wait_for_dv_success() instead.",
Copy link
Copy Markdown
Contributor

@jpeimer jpeimer Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapper hasn't branched yet. We planned to remove it in the next version (4.23) ?

Copy link
Copy Markdown
Contributor Author

@ema-aka-young ema-aka-young Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I thought it would be possible to include this as we haven't branched yet...

category=DeprecationWarning,
stacklevel=2,
)
if wait_for_exists_only:
return super().wait(timeout=timeout, sleep=sleep)
else:
self._check_none_pending_status(failure_timeout=failure_timeout)

# If DV's status is not Pending, continue with the flow
self.wait_for_status(status=self.Status.SUCCEEDED, timeout=timeout)
self.pvc.wait_for_status(status=PersistentVolumeClaim.Status.BOUND, timeout=timeout)
return None

@property
def pvc(self):
return PersistentVolumeClaim(
Expand Down