between supports Date/IDate with missing bounds#7751
Open
grcatlin wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7751 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 87 87
Lines 17065 17071 +6
=======================================
+ Hits 16902 16908 +6
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-schwen
reviewed
May 21, 2026
| # errors name the bound that failed coercion | ||
| x = as.Date("2020-01-01") + 0:4 | ||
| test(2038.39, between(x, "not-a-date", "2020-01-04"), error="Date while 'lower' was not, coercion to Date failed") | ||
| test(2038.40, between(x, "2020-01-02", "not-a-date"), error="Date while 'upper' was not, coercion to Date failed") |
Member
There was a problem hiding this comment.
not sure we need both and 2038.39 and 2038.40
ben-schwen
reviewed
May 21, 2026
Comment on lines
+14691
to
+14694
| x = data.table(Date = as.Date("2020-01-01") + 0:5, Active = c(TRUE, FALSE, TRUE, FALSE, TRUE, FALSE)) | ||
| x[Active == TRUE, InRange := c(TRUE, FALSE, TRUE)] | ||
| x[InRange == TRUE, c("RangeBegin", "RangeEnd") := list(Date - 1L, Date + 1L)] | ||
| x[InRange == FALSE, c("RangeBegin", "RangeEnd") := list(Date + 1L, Date + 2L)] |
Member
There was a problem hiding this comment.
I would rather build x with a single step, like e.g.
Suggested change
| x = data.table(Date = as.Date("2020-01-01") + 0:5, Active = c(TRUE, FALSE, TRUE, FALSE, TRUE, FALSE)) | |
| x[Active == TRUE, InRange := c(TRUE, FALSE, TRUE)] | |
| x[InRange == TRUE, c("RangeBegin", "RangeEnd") := list(Date - 1L, Date + 1L)] | |
| x[InRange == FALSE, c("RangeBegin", "RangeEnd") := list(Date + 1L, Date + 2L)] | |
| x = data.table( | |
| Date = as.Date("2020-01-01") + 0:5, | |
| Active = c(TRUE, FALSE, TRUE, FALSE, TRUE, FALSE), | |
| InRange = c(TRUE, NA, FALSE, NA, TRUE, NA), | |
| RangeBegin = as.Date("2020-01-01") + c(-1L, NA, 3L, NA, 3L, NA), | |
| RangeEnd = as.Date("2020-01-01") + c( 1L, NA, 4L, NA, 5L, NA) | |
| ) |
ben-schwen
reviewed
May 21, 2026
| x[InRange == FALSE, c("RangeBegin", "RangeEnd") := list(Date + 1L, Date + 2L)] | ||
| test(2038.36, x[Active == TRUE & between(Date, RangeBegin, RangeEnd), Date], as.Date(c("2020-01-01", "2020-01-05"))) | ||
| # Date character bounds coercion | ||
| test(2038.37, between(x$Date, "2020-01-02", "2020-01-04"), c(FALSE, TRUE, TRUE, TRUE, FALSE, FALSE)) |
Member
There was a problem hiding this comment.
This test does not fail pre the PR, so its probably covering the same lines (just food for thought)
ben-schwen
approved these changes
May 21, 2026
Member
ben-schwen
left a comment
ben-schwen
left a comment
There was a problem hiding this comment.
code change LGTM. some minor things about the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7281
I believe this implementation matches @aitap's suggestion, where Date/IDates are passed to the C code directly. I tried to line up the character bound parsing with the existing implementation for
POSIXct.This is my first time contributing to
data.tableand I'd appreciate any feedback!