refactor: add timer to hybrid click - #30
Merged
Merged
Conversation
Slight tweak to "Snap then cycle" Fixes #29
There was a problem hiding this comment.
Pull request overview
This PR adjusts the “Snap Then Cycle” hybrid behavior so that cycling only occurs on a quick re-click/re-press, addressing the UX concern in issue #29 where users could accidentally start cycling when they only intended to re-snap/confirm alignment.
Changes:
- Added a 2-second timeout window for “Snap Then Cycle” so cycling only happens on a quick repeat action while already on an allowed cardinal.
- Updated config UI descriptions and README documentation to reflect the new timing-based behavior.
- Bumped plugin version to 1.2.4.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/compassCameraControl/CompassCameraControlPlugin.java | Adds timestamp tracking and timeout-gated cycling for the hybrid “Snap Then Cycle” action. |
| src/main/java/com/compassCameraControl/CompassCameraControlConfig.java | Updates configuration descriptions to match the new “quick re-press within 2 seconds” behavior. |
| README.md | Documents the new timeout-based “Snap Then Cycle” UX. |
| runelite-plugin.properties | Version bump to 1.2.4. |
| build.gradle | Version bump to 1.2.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight tweak to "Snap then cycle"
Fixes #29