Give darken a target so the telescope background can be darker - #121
Open
rokokol wants to merge 1 commit into
Open
Give darken a target so the telescope background can be darker#121rokokol wants to merge 1 commit into
rokokol wants to merge 1 commit into
Conversation
darken(M.colors.base00, 0.1) cannot return anything but base00, because darken blends its argument towards base00 rather than darkening it. Its seven other callers depend on exactly that, so this adds an optional target rather than changing what the function does by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120.
darken(M.colors.base00, 0.1)cannot return anything butbase00, becausedarkenblends its argument towardsbase00rather than darkening it. Its seven other callers depend on exactly that —darken(base0B, 0.85)is howDiffAdd's background is arrived at — so this adds an optional target instead of changing what the function does by default.Measured on both stock schemes,
nvim --cleanwith the plugin prepended toruntimepath:TelescopeNormalTelescopePromptNormalTelescopePreviewLineDiffAddDiffDeletedefault-darkbefore#181818#343434#282828#2C2F24#261C1Cdefault-darkafter#151515#343434#282828#2C2F24#261C1Cdefault-lightbefore#F8F8F8#DBDBDB#E8E8E8#EAEDE3#F0E6E5default-lightafter#DFDFDF#DBDBDB#E8E8E8#EAEDE3#F0E6E5Normalis#181818and#F8F8F8respectively, soTelescopeNormalmoves off it and nothing else moves at all.