Refactor controller_track and system_trace - #981
Open
amokiche-amd wants to merge 17 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amokiche-amd
changed the title
amokiche-amd
marked this pull request as ready for review
August 10, 2026 15:39
amokiche-amd
requested review from
drchen-amd,
tomk-amd and
vstempen
as code owners
August 10, 2026 15:39
tomk-amd
reviewed
Aug 24, 2026
| case kRPVControllerTrackNumberOfEntries: | ||
| { | ||
| *value = m_num_entries; | ||
| *value = m_bounds.num_entries; |
Collaborator
There was a problem hiding this comment.
use GetNumberOfEntries() to prevent risk of ABI getters drifting from C++ interface
Comment on lines
652
to
658
| case kRPVControllerTrackType: | ||
| { | ||
| *value = m_type; | ||
| result = kRocProfVisResultSuccess; | ||
| break; | ||
| } | ||
| case kRPVControllerTrackNumberOfEntries: |
Collaborator
There was a problem hiding this comment.
use GetTrackType() instead of m_type to prevent risk of ABI getters drifting from C++ interface
drchen-amd
reviewed
Aug 24, 2026
drchen-amd
left a comment
drchen-amd
left a comment
Member
There was a problem hiding this comment.
I don't mind this new approach of using more C++ features and directly calling functions on the objects internally instead of enum. I also do not mind sticking to C style and using enums internally.
I think new approach will lead to some bloating as for each exposed field you end up with an enum version and a direct call version.
If we proceed, this will need more hardening because I only tested for a few minutes and noticed:
- Queue utilization and counter track stats are broken.
- Panning and zooming will debug assert:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor controller Track and System_trace files to replace of usage default getters to direct getters and setters.
Refactor giant functions to increase code readability.
Small minor refactors.
Technical Details
Test Plan
Test Result
Submission Checklist