Skip to content

Fix CVE vulnerabilities: upgrade Go 1.22→1.26 and dependencies - #50

Merged
spraveenio merged 2 commits into
ROCm:mainfrom
bhatnitish:sync/cve-go-upgrade
Jun 18, 2026
Merged

spraveenio merged 2 commits into
ROCm:mainfrom
bhatnitish:sync/cve-go-upgrade

Conversation

@bhatnitish

Copy link
Copy Markdown
Contributor

Summary

  • Upgrades Go from 1.22.0 to 1.26.4 in go.mod and all Dockerfiles
  • Bumps dependency versions to address CVE vulnerabilities (grpc, docker/cli, otel, golang.org/x/net, golang.org/x/oauth2, and others)
  • Updates alpine base image from 3.19 to 3.24 in worker/operator-build Dockerfiles to match Go 1.26 availability
  • Fixes FROM ... as → FROM ... AS casing lint warnings

Cherry-picked from pensando/kernel-module-management:

  • 20fc630 Fix CVE vulnerabilities by upgrading Go and dependencies
  • 8a253a0 Fix Go version mismatch in Dockerfiles after CVE upgrade

Conflicts resolved by substituting internal registry references (registry.test.pensando.io:5000/golang:1.26) with the equivalent public images (docker.io/golang:1.26). The pensando-internal .job.yml CI file was excluded as it has no equivalent in this repo.

Test plan

  • Verify docker build succeeds for Dockerfile, Dockerfile.webhook, Dockerfile.worker, Dockerfile.kmm-operator-build, Dockerfile.signimage
  • Verify go build ./... passes with Go 1.26
  • Run existing test suite

bhatnitish and others added 2 commits June 18, 2026 17:18
Upgrade Go from 1.22/1.23 to 1.26.4, and bump google.golang.org/grpc
(v1.65.0 → v1.79.3), github.com/docker/cli (v27.1.1 → v29.2.0),
go.opentelemetry.io/otel/sdk (v1.28.0 → v1.43.0), golang.org/x/net
(v0.28.0 → v0.48.0), and golang.org/x/oauth2 (v0.21.0 → v0.34.0)
to resolve all Trivy-reported CVEs including CRITICAL CVE-2026-33186
and CVE-2025-68121.

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
* Fix Go version mismatch in Dockerfiles after CVE upgrade

The CVE fix (20fc630) bumped go.mod to Go 1.26.4 and updated the main
Dockerfile, but missed Dockerfile.webhook, Dockerfile.worker, and
Dockerfile.kmm-operator-build which still referenced Go 1.23. This
caused "go.mod requires go >= 1.26.4 (running go 1.23.5)" build
failures. Also updates the alpine variant from 3.19 to 3.24 to match
Go 1.26 availability, and fixes FROM/AS casing lint warnings.

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>

* Add all image build targets to root CI sanity job

Replace dummy-sanity-job with sanity-build target that depends on all 4
image builds (operator, webhook, worker, signer). This catches
Dockerfile and build issues at PR time instead of nightly build time.

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4 <noreply@anthropic.com>

@spraveenio spraveenio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spraveenio
spraveenio merged commit 7b7d821 into ROCm:main Jun 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants