Skip to content

[CP 1687] docs(npd): add minimal dmesg-only NPD example - #659

Merged
spraveenio merged 2 commits into
ROCm:mainfrom
ci-penbot-01:CP.O2O.pensando.gpu-operator.1687.rocm.gpu-operator.main
Sep 25, 2026
Merged

spraveenio merged 2 commits into
ROCm:mainfrom
ci-penbot-01:CP.O2O.pensando.gpu-operator.1687.rocm.gpu-operator.main

Conversation

@ci-penbot-01

Copy link
Copy Markdown
Contributor

cp of pensando/gpu-operator#1687


Source PR Description (pensando/gpu-operator#1687):

Summary

  • Adds docs/npd/npd-dmesg-example.md: a self-contained, three-manifest walkthrough for detecting AMD GPU kernel crashes via NPD's built-in system-log-monitor (no AMD Device Metrics Exporter / amdgpuhealth required).
  • Covers: minimal RBAC, kernel-monitor.json ConfigMap with amdgpu.* regex rules (page fault, hang, reset, RAS error), stripped DaemonSet mounting only /dev/kmsg, and verify steps.

Plan: docs-internal/knowledge/plans/2026-09-24-npd-dmesg-example-doc.md

Test plan

  • Markdown renders without errors (markdownlint)
  • YAML blocks in the doc are valid YAML
  • Links to node-problem-detector.md and ../autoremediation/auto-remediation.md resolve

🤖 Generated with Claude Code

Cherrypick triggered by: ACP-Automation

* docs(npd): add minimal dmesg-only NPD example

Add docs/npd/npd-dmesg-example.md with a self-contained walkthrough
for watching /dev/kmsg for AMD GPU kernel crashes using only NPD's
built-in system-log monitor. No AMD Device Metrics Exporter or
amdgpuhealth required.

Covers RBAC, kernel-monitor.json ConfigMap with amdgpu.* regex rules
(page fault, hang, reset, RAS error), a stripped DaemonSet with only
/dev/kmsg mounted, and verify steps.

Plan: docs-internal/knowledge/plans/2026-09-24-npd-dmesg-example-doc.md

Co-Authored-By: Claude <noreply@anthropic.com>

* docs(npd): rewrite dmesg example to integrate with GPU Operator auto-remediation

Update npd-dmesg-example.md to use the operator-integrated NPD pattern:
- dmesg system-log-monitor runs alongside amdgpuhealth custom plugin monitor
- AMDGPUKernelCrash permanent condition wires into remediation ConfigMap
- DaemonSet includes amd-gpu-unhealthy:NoSchedule toleration required by auto-remediation
- Added remediation ConfigMap snippet showing nodeCondition alignment

Add npd-dmesg-example to _toc.yml under Node Problem Detector section.

Add new spellcheck wordlist entries for GPU condition/config terms used in the doc.

Co-Authored-By: Claude <noreply@anthropic.com>

* docs(npd): fix MD040 bare fenced code blocks

Add 'text' language tag to the ASCII flow diagram and kubectl output
blocks to satisfy markdownlint MD040 (fenced code blocks must have
a language specified).

Co-Authored-By: Claude <noreply@anthropic.com>

* docs(npd): fix MD060 table column alignment

Pad table separator rows and cell content to align all pipes,
satisfying markdownlint MD060 (table-column-style aligned).

Co-Authored-By: Claude <noreply@anthropic.com>

* Add dmesg Kernel-Crash Detection example to TOC

---------

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit 5fc38bae68f36ff1fd2a5cdd0f023701cedbad4a)
@ci-penbot-01

Copy link
Copy Markdown
Contributor Author

AI-Assisted Cherry-Pick

Source PR: #1687
Target Branch: main

The cherry-pick operation encountered merge conflicts which were resolved automatically using AI assistance.

Files with conflicts (resolved by AI):

  • .wordlist.txt:43-46
  • .wordlist.txt:617-632
  • .wordlist.txt:876-879
  • .wordlist.txt:975-979
  • .wordlist.txt:1022-1025
  • .wordlist.txt:1132-1135
Original conflict in .wordlist.txt
<<<<<<< HEAD
=======
AutoPartition
>>>>>>> 5fc38bae... docs(npd): add minimal dmesg-only NPD example (#1687)
Original conflict in .wordlist.txt
<<<<<<< HEAD
args
=======
amd64
argoproj
args
arm64
>>>>>>> 5fc38bae... docs(npd): add minimal dmesg-only NPD example (#1687)
Original conflict in .wordlist.txt
<<<<<<< HEAD
=======
le
>>>>>>> 5fc38bae... docs(npd): add minimal dmesg-only NPD example (#1687)
Original conflict in .wordlist.txt
<<<<<<< HEAD
=======
ppc
ppc64le
>>>>>>> 5fc38bae... docs(npd): add minimal dmesg-only NPD example (#1687)
Original conflict in .wordlist.txt
<<<<<<< HEAD
=======
repartitions
>>>>>>> 5fc38bae... docs(npd): add minimal dmesg-only NPD example (#1687)
Original conflict in .wordlist.txt
<<<<<<< HEAD
=======
tonistiigi
>>>>>>> 5fc38bae... docs(npd): add minimal dmesg-only NPD example (#1687)

Cherry-pick triggered by: ACP-Automation

@spraveenio
spraveenio merged commit 430cb6c into ROCm:main Sep 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants