Skip to content

fix: remove hardcoded Grafana credentials - #654

Merged
spraveenio merged 1 commit into
ROCm:mainfrom
yansun1996:user/yansun1996/fix-gitleaks-monitor-auth
Sep 23, 2026
Merged

spraveenio merged 1 commit into
ROCm:mainfrom
yansun1996:user/yansun1996/fix-gitleaks-monitor-auth

Conversation

@yansun1996

Copy link
Copy Markdown
Member

Summary

  • Remove the hardcoded admin:admin credential from the Prometheus monitoring example.
  • Allow Grafana credentials to be supplied with GRAFANA_USER and GRAFANA_PASSWORD, retaining the current defaults.
  • Pass the configured credentials to the Grafana container and API request.

Validation

  • bash -n example/prometheus/monitor.sh
  • Local Gitleaks v8.30.1 scan over public/main..HEAD: no leaks found.

@spraveenio spraveenio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spraveenio
spraveenio merged commit 9dc1cac into ROCm:main Sep 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants