Skip to content

fix(gpuagent): widen ECC block iterator to uint64_t for amdsmi 27.1.0 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarat-k merged 1 commit into from
Sep 24, 2026
Merged

fix(gpuagent): widen ECC block iterator to uint64_t for amdsmi 27.1.0 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sw/nic/gpuagent/api/smi/amdsmi/smi_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,7 @@ smi_fill_ecc_stats_ (aga_gpu_handle_t gpu_handle,
uint64_t total_correctable_count = 0;
uint64_t total_uncorrectable_count = 0;
// get correctable and uncorrectable total error count beforehand
for (uint32_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
for (uint64_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
b = b * 2) {
// initialize ec to all 0s
ec = { 0 };
Expand Down
2 changes: 1 addition & 1 deletion sw/nic/gpuagent/api/smi/amdsmi/smi_state.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ smi_state::smi_watcher_update_all_watch_fields_(uint32_t gpu_id,
}

// get correctable and uncorrectable total error count beforehand
for (uint32_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
for (uint64_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
b = b * 2) {
// initialize ec to all 0s
ec = { 0 };
Expand Down
2 changes: 1 addition & 1 deletion sw/nic/gpuagent/api/smi/gimamdsmi/smi_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ smi_fill_ecc_stats_ (aga_gpu_handle_t gpu_handle,
uint64_t total_correctable_count = 0;
uint64_t total_uncorrectable_count = 0;
// get correctable and uncorrectable total error count beforehand
for (uint32_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
for (uint64_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
b = b * 2) {
// initialize ec to all 0s
ec = { 0 };
Expand Down
2 changes: 1 addition & 1 deletion sw/nic/gpuagent/api/smi/gimamdsmi/smi_state.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ smi_state::smi_watcher_update_all_watch_fields_(uint32_t gpu_id,
watch_db->watch_info[gpu_id] = { 0 };

// get correctable and uncorrectable total error count beforehand
for (uint32_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
for (uint64_t b = AMDSMI_GPU_BLOCK_FIRST; b <= AMDSMI_GPU_BLOCK_LAST;
b = b * 2) {
// initialize ec to all 0s
ec = { 0 };
Expand Down
22 changes: 21 additions & 1 deletion sw/nic/third-party/rocm/amd_smi_lib/include/amd_smi/amdsmi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1783,7 +1783,27 @@ typedef enum {
AMDSMI_GPU_BLOCK_JPEG = (1ULL << 16), //!< JPEG block
AMDSMI_GPU_BLOCK_IH = (1ULL << 17), //!< IH block
AMDSMI_GPU_BLOCK_MPIO = (1ULL << 18), //!< MPIO block
AMDSMI_GPU_BLOCK_LAST = AMDSMI_GPU_BLOCK_MPIO,
AMDSMI_GPU_BLOCK_MMSCH = (1ULL << 19), //!< MMSCH block
AMDSMI_GPU_BLOCK_MP5 = (1ULL << 20), //!< MP5 block
AMDSMI_GPU_BLOCK_ATU = (1ULL << 21), //!< ATU block
AMDSMI_GPU_BLOCK_DACC_BE = (1ULL << 22), //!< DACC_BE block
AMDSMI_GPU_BLOCK_ECLR = (1ULL << 23), //!< ECLR block
AMDSMI_GPU_BLOCK_KPX_SERDES = (1ULL << 24), //!< KPX_SERDES block
AMDSMI_GPU_BLOCK_LSDMA = (1ULL << 25), //!< LSDMA block
AMDSMI_GPU_BLOCK_MPART = (1ULL << 26), //!< MPART block
AMDSMI_GPU_BLOCK_MPIFOE = (1ULL << 27), //!< MPIFOE block
AMDSMI_GPU_BLOCK_MPRAS = (1ULL << 28), //!< MPRAS block
AMDSMI_GPU_BLOCK_NBIF = (1ULL << 29), //!< NBIF block
AMDSMI_GPU_BLOCK_NBIO = (1ULL << 30), //!< NBIO block
AMDSMI_GPU_BLOCK_OXRP = (1ULL << 31), //!< OXRP block
AMDSMI_GPU_BLOCK_PCIE_PL = (1ULL << 32), //!< PCIE_PL block
AMDSMI_GPU_BLOCK_PCS_XGMI = (1ULL << 33), //!< PCS_XGMI block
AMDSMI_GPU_BLOCK_PIE = (1ULL << 34), //!< PIE block
AMDSMI_GPU_BLOCK_CS = (1ULL << 35), //!< CS block
AMDSMI_GPU_BLOCK_SHUB = (1ULL << 36), //!< SHUB block
AMDSMI_GPU_BLOCK_SSBDCI = (1ULL << 37), //!< SSBDCI block
AMDSMI_GPU_BLOCK_UCIE_PCS = (1ULL << 38), //!< UCIE_PCS block
AMDSMI_GPU_BLOCK_LAST = AMDSMI_GPU_BLOCK_UCIE_PCS,
AMDSMI_GPU_BLOCK_RESERVED = (1ULL << 63)
} amdsmi_gpu_block_t;

Expand Down
2 changes: 1 addition & 1 deletion sw/nic/third-party/rocm/amd_smi_lib/version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
therock-10.1.0a20260812
27.1.0+4c2f7505
Binary file modified sw/nic/third-party/rocm/amd_smi_lib/x86_64/lib/libamd_smi.so.27.0.0
View file
Open in desktop
Binary file not shown.
Loading