Skip to content

fix(dyninst): Fix use-after-unmap from filename-keyed DwarfHandle cache #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgaliffiAMD merged 1 commit into from
Aug 22, 2026
Merged

fix(dyninst): Fix use-after-unmap from filename-keyed DwarfHandle cache #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dwarf/src/dwarfHandle.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,12 @@ DwarfHandle::ptr DwarfHandle::createDwarfHandle(string filename_, Elf_X *file_,
map<string, DwarfHandle::ptr>::iterator i;
i = all_dwarf_handles.find(filename_);
if (i != all_dwarf_handles.end()) {
return i->second;
if (i->second->origFile() == file_)
return i->second;
// A different Elf_X for a path we have already seen may mean the image
// the cached handle was built from has been closed underneath.
// Returning it would make DWARF parsing read an unmapped image.
all_dwarf_handles.erase(i);
}

DwarfHandle::ptr ret = DwarfHandle::ptr(
Expand Down