[workflows] [Do not review] Experimentation - #28
Closed
kcossett-amd wants to merge 9 commits into
Closed
Conversation
kcossett-amd
force-pushed
the
users/kcossett-amd/dyninst-workflows
branch
2 times, most recently
from
August 11, 2026 15:01
438d128 to
731bb0a
Compare
Author
|
It turns out naming the directory dyninst causes problems :( |
RHEL 10 (gcc 14.3.1) is the only image in the CI matrix new enough to reach these three diagnostics, each of which is fatal under DYNINST_WARNINGS_AS_ERRORS. Annotatable.h passed calloc its arguments transposed, tripping gcc 14's -Wcalloc-transposed-args. The allocation size is unchanged. indexed_symbols::erase discarded the result of std::remove, which gcc 14's libstdc++ marks [[nodiscard]]. This was a real defect rather than a diagnostic nuisance: std::remove shifts the survivors down and returns the new logical end, so ignoring it left each vector at its original length with a stale duplicate in the tail, and did not remove the symbol at all when it was the last element. Completed to the erase-remove idiom. gcc 14 compiles the buildTables() lambda to a 74560-byte frame, but DyninstWarnings.cmake populated the non-debug power-opcode-table override only for gcc 7 and clang, so gcc 14 fell through to the 20480 default. Added a gcc 14+ arm at 76800, the worst case already documented for this file. The Annotatable.h and indexed_symbols.hpp changes match upstream master. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Everything checks out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is just a test
Technical Details
Test Plan
Test Result
Submission Checklist