[BBots] Use TheRock nightly in bot image#2252
Merged
jplehr merged 1 commit intoJun 11, 2026
Merged
Conversation
To live closer to the development version of ROCm, switch the way that we install ROCm from a long-living release to a nightly artifact from TheRock. This will download the "latest" nightly when no specific date is given but accepts an override to pin to a specific date for reproducibility.
jplehr
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
Kewen12
approved these changes
Jun 11, 2026
Kewen12
left a comment
Kewen12
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
The helper scripts are identical, we could combine the them in the future work.
Contributor
Author
With this change, large parts of the actual images are identical, so the next step is to only use a single one. But I wanted to split it for ease of review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To live closer to the development version of ROCm, switch the way that we install ROCm from a long-living release to a nightly artifact from TheRock.
Long-term this also paves the way to unify the fleet image into a single one.
Technical Details
This will download the "latest" nightly when no specific date is given but accepts an override to pin to a specific date for reproducibility.
Test Plan
Manual testing
Test Result
Able to execute upstream bot recipes inside the container.