ci: bump te-rocm-wheels artifact retention 1d -> 5d#673
Open
wenchenvincent wants to merge 1 commit into
Open
Conversation
The te-rocm-wheels build artifact is consumed by sGPU and mGPU test jobs downstream of the build. mi35x self-hosted runners can queue for 24-36h before starting, so the previous retention-days: 1 racing the queue makes every mi35x job (and any slow-queueing mi30x job) fail at the download step with "Artifact not found for name: te-rocm-wheels". 5 days matches the retention already used for test-log artifacts in rocm-ci.yml and comfortably outlasts observed mi35x queue times. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
There was a discussion regarding this retention here: #591 Not sure if the concerns still apply. |
Collaborator
Indeed. With QoLA+CK-JIT added resulted binary size deflated x3, so it should be OK to increase retention period to 2 or 3 days w/o extra actions. But further extending increases risk of running out of space. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retention-dayson thete-rocm-wheelsartifact upload in.github/workflows/rocm-wheels-build.ymlfrom1to5.Why
The
te-rocm-wheelsbuild artifact is downloaded by every downstream sGPU / mGPU test job. mi35x self-hosted runners have observed queue times of 24–36 hours before a job actually starts, which races the previous 1-day retention window. Every mi35x job on recent PRs has failed at the download step with:Observed on PR #667 run 29390452937:
Bumping to
5days matches the retention already used for test-log artifacts inrocm-ci.yml(also5) and comfortably outlasts the mi35x queue tail.Test plan
te-rocm-wheelssuccessfully.🤖 Generated with Claude Code