Skip to content

feat(ci): add test_runs_on input to test_native_linux_packages_instal - #6404

Merged
arvindcheru merged 4 commits into
mainfrom
users/nunnikri/native-test-runs-on-input
Aug 22, 2026
Merged

feat(ci): add test_runs_on input to test_native_linux_packages_instal #6404
arvindcheru merged 4 commits into
mainfrom
users/nunnikri/native-test-runs-on-input

Conversation

@nunnikri

@nunnikri nunnikri commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Adds a test_runs_on input (matching the pattern used by test_component.yml, test_pytorch_wheels.yml, and test_rocm_wheels.yml) so callers can override the runner without editing the workflow. Defaults to the existing linux-gfx942-1gpu-ccs-csp-ossci-rocm label so no caller changes are needed.

Motivation

The test_native_linux_packages_install workflow had the runner label (linux-gfx942-1gpu-ccs-csp-ossci-rocm) hardcoded directly in the runs-on field, with no way for callers to override it without editing the workflow itself. All other reusable test workflows (test_component.yml, test_pytorch_wheels.yml, test_rocm_wheels.yml) already expose a test_runs_on input for this purpose. This change brings test_native_linux_packages_install in line with that established pattern.

Technical Details

Adds a test_runs_on input to both the workflow_call and workflow_dispatch trigger blocks of .github/workflows/test_native_linux_packages_install.yml, defaulting to linux-gfx942-1gpu-ccs-csp-ossci-rocm (the previously hardcoded value). The runs-on field is updated to use inputs.test_runs_on instead of the hardcoded string:

runs-on: ${{ github.repository_owner == 'ROCm' && inputs.test_runs_on || 'ubuntu-24.04' }}

No changes are required to existing callers (multi_arch_ci_linux.yml, multi_arch_release_linux.yml) — the default preserves the current behavior. The input is purely additive and allows callers or manual dispatches to target a different runner pool when needed (e.g., sandbox runners, alternative GPU pools).

Test Plan

Successful ci run should be good enough test as it test the build and install test run

https://github.com/ROCm/TheRock/actions/runs/32546260115

…l workflow

Adds a test_runs_on input (matching the pattern used by test_component.yml,
test_pytorch_wheels.yml, and test_rocm_wheels.yml) so callers can override
the runner without editing the workflow. Defaults to the existing
linux-gfx942-1gpu-ccs-csp-ossci-rocm label so no caller changes are needed.

Co-Authored-By: Claude <noreply@anthropic.com>
@therock-pr-bot

therock-pr-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
JIRA ID (on separate line)
ROCM-25757
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID (on separate line)
AIRUNTIME-2352
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 7, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@nunnikri
nunnikri requested a review from raramakr as a code owner August 19, 2026 16:29
Comment thread .github/workflows/test_native_linux_packages_install.yml

@arvindcheru arvindcheru left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindcheru
arvindcheru merged commit ab92319 into main Aug 22, 2026
174 of 182 checks passed
@arvindcheru
arvindcheru deleted the users/nunnikri/native-test-runs-on-input branch August 22, 2026 02:42
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants