feat(ci): add test_runs_on input to test_native_linux_packages_instal - #6404
Merged
Conversation
…l workflow Adds a test_runs_on input (matching the pattern used by test_component.yml, test_pytorch_wheels.yml, and test_rocm_wheels.yml) so callers can override the runner without editing the workflow. Defaults to the existing linux-gfx942-1gpu-ccs-csp-ossci-rocm label so no caller changes are needed. Co-Authored-By: Claude <noreply@anthropic.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
arvindcheru
reviewed
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test_runs_on input (matching the pattern used by test_component.yml, test_pytorch_wheels.yml, and test_rocm_wheels.yml) so callers can override the runner without editing the workflow. Defaults to the existing linux-gfx942-1gpu-ccs-csp-ossci-rocm label so no caller changes are needed.
Motivation
The test_native_linux_packages_install workflow had the runner label (linux-gfx942-1gpu-ccs-csp-ossci-rocm) hardcoded directly in the runs-on field, with no way for callers to override it without editing the workflow itself. All other reusable test workflows (test_component.yml, test_pytorch_wheels.yml, test_rocm_wheels.yml) already expose a test_runs_on input for this purpose. This change brings test_native_linux_packages_install in line with that established pattern.
Technical Details
Adds a test_runs_on input to both the workflow_call and workflow_dispatch trigger blocks of .github/workflows/test_native_linux_packages_install.yml, defaulting to linux-gfx942-1gpu-ccs-csp-ossci-rocm (the previously hardcoded value). The runs-on field is updated to use inputs.test_runs_on instead of the hardcoded string:
runs-on: ${{ github.repository_owner == 'ROCm' && inputs.test_runs_on || 'ubuntu-24.04' }}No changes are required to existing callers (multi_arch_ci_linux.yml, multi_arch_release_linux.yml) — the default preserves the current behavior. The input is purely additive and allows callers or manual dispatches to target a different runner pool when needed (e.g., sandbox runners, alternative GPU pools).
Test Plan
Successful ci run should be good enough test as it test the build and install test run
https://github.com/ROCm/TheRock/actions/runs/32546260115