Skip to content

[don't merge] [debug-tools] Enable multi-arch CI - #5977

Closed
lumachad wants to merge 1 commit into
mainfrom
users/lumachad/rocgdb/multi-arch-ci
Closed

[don't merge] [debug-tools] Enable multi-arch CI#5977
lumachad wants to merge 1 commit into
mainfrom
users/lumachad/rocgdb/multi-arch-ci

Conversation

@lumachad

@lumachad lumachad commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Enable ROCgdb multi-arch CI cross-triggers. Fix bugs and add unit tests.

@lumachad lumachad added the ci:skip Skip all CI builds/tests for this PR label Jun 19, 2026
@lumachad

lumachad commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

ci:skip as this is still under validation against a ROCgdb counterpart: ROCm/ROCgdb#179

@lumachad
lumachad force-pushed the users/lumachad/rocgdb/multi-arch-ci branch 4 times, most recently from fe1dcd4 to b7e90da Compare June 22, 2026 07:58
@lumachad lumachad changed the title [debug-tools] Enable multi-arch CI [don't merge] [debug-tools] Enable multi-arch CI Jun 22, 2026
@lumachad
lumachad force-pushed the users/lumachad/rocgdb/multi-arch-ci branch from b7e90da to 5619c54 Compare June 23, 2026 17:29
@therock-pr-bot

therock-pr-bot Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jun 23, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@lumachad
lumachad force-pushed the users/lumachad/rocgdb/multi-arch-ci branch from 5619c54 to 8448898 Compare June 23, 2026 17:57
@lumachad
lumachad force-pushed the users/lumachad/rocgdb/multi-arch-ci branch 2 times, most recently from 065cd92 to a44a8ca Compare July 10, 2026 11:24
lumachad added a commit to ROCm/ROCgdb that referenced this pull request Jul 10, 2026
@lumachad
ci: pin TheRock ref to a44a8cae2d8 (ROCm/TheRock#5977)
09c6003 
Pin all multi-arch CI workflows to the head commit of
ROCm/TheRock#5977 (users/lumachad/rocgdb/multi-arch-ci).
@lumachad
lumachad force-pushed the users/lumachad/rocgdb/multi-arch-ci branch 3 times, most recently from bccdb64 to e522c2f Compare July 10, 2026 12:12
lumachad added a commit to ROCm/ROCgdb that referenced this pull request Jul 10, 2026
@lumachad
ci: pin TheRock ref to e522c2fc2ea (ROCm/TheRock#5977)
0271125 
Pin all multi-arch CI workflows to the head commit of
ROCm/TheRock#5977 (users/lumachad/rocgdb/multi-arch-ci).
@lumachad
lumachad force-pushed the users/lumachad/rocgdb/multi-arch-ci branch from e522c2f to d3082fa Compare July 10, 2026 15:28
lumachad added a commit to ROCm/ROCgdb that referenced this pull request Jul 10, 2026
@lumachad
ci: pin TheRock ref to d3082fa3203 (ROCm/TheRock#5977)
16c55c8 
Pin all multi-arch CI workflows to the head commit of
ROCm/TheRock#5977 (users/lumachad/rocgdb/multi-arch-ci).
@lumachad @claude
ci: add skip_packaging to suppress Python packaging for external repos
a1b827f 
External component repos that only need ROCm build artifacts (such as
rocgdb) can now set skip_packaging in their external_repo JSON to skip
the Python, PyTorch, and native Linux packaging jobs entirely.

configure_multi_arch_ci.py reads skip_packaging from EXTERNAL_REPO_JSON
and gates build_native_linux, build_python_packages, and build_pytorch on
it. The build_python_packages field is added to BuildConfig so the Linux
and Windows CI workflows can condition their packaging and package-test
jobs on it. setup_multi_arch.yml forwards the caller's external_repo JSON
to the configure step.

Stage scoping for external repos is handled by the existing prebuilt_stages
and baseline_run_id inputs, so the caller passes those through directly and
no derivation is needed here.

Co-Authored-By: Claude <noreply@anthropic.com>
@lumachad
lumachad force-pushed the users/lumachad/rocgdb/multi-arch-ci branch from d3082fa to a1b827f Compare July 30, 2026 17:31
lumachad added a commit to ROCm/ROCgdb that referenced this pull request Jul 30, 2026
@lumachad
ci: pin TheRock ref to d3082fa3203 (ROCm/TheRock#5977)
3d47c76 
Pin all multi-arch CI workflows to the head commit of
ROCm/TheRock#5977 (users/lumachad/rocgdb/multi-arch-ci).
lumachad added a commit to ROCm/ROCgdb that referenced this pull request Jul 30, 2026
@lumachad @claude
ci: pin TheRock ref to a1b827fc5bb (ROCm/TheRock#5977)
3fb84ba 
Update the pinned TheRock commit in both multi-arch CI workflows
(release and ASAN) to a1b827fc5bb, which adds skip_packaging support
for external repos. Also add skip_packaging: true to the external_repo
JSON so rocgdb builds skip Python and PyTorch packaging entirely.

Co-Authored-By: Claude <noreply@anthropic.com>
@lumachad

lumachad commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Dropping. I'll start from scratch from what's in place.

@lumachad lumachad closed this Aug 11, 2026
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Aug 11, 2026
lumachad added a commit to ROCm/ROCgdb that referenced this pull request Aug 11, 2026
@lumachad
ci: pin TheRock ref to d3082fa3203 (ROCm/TheRock#5977)
3e189cc 
Pin all multi-arch CI workflows to the head commit of
ROCm/TheRock#5977 (users/lumachad/rocgdb/multi-arch-ci).
lumachad added a commit to ROCm/ROCgdb that referenced this pull request Aug 11, 2026
@lumachad @claude
ci: pin TheRock ref to a1b827fc5bb (ROCm/TheRock#5977)
d40f6c9 
Update the pinned TheRock commit in both multi-arch CI workflows
(release and ASAN) to a1b827fc5bb, which adds skip_packaging support
for external repos. Also add skip_packaging: true to the external_repo
JSON so rocgdb builds skip Python and PyTorch packaging entirely.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScottTodd ScottTodd Awaiting requested review from ScottTodd ScottTodd will be requested when the pull request is marked ready for review ScottTodd is a code owner

Assignees

No one assigned

Labels

ci:skip Skip all CI builds/tests for this PR Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

TheRock Triage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lumachad