gdb.rocm/hip-builtin-completions: simplify the checks - #301
Merged
Conversation
amd-shahab
commented
Aug 21, 2026
amd-shahab
commented
Contributor
In a previous patch [1], gdb_test_multiple constructs were added to handle cases that there could be more than one suggestion for the "complete" command's output. This change achieves the same goal with "gdb_test". [1] b5151b0 in amd-staging
amd-shahab
force-pushed
the
users/shvahedi/hip-completion-simplify
branch
from
August 21, 2026 09:27
7e83084 to
6ce5a23
Compare
lancesix
approved these changes
Aug 21, 2026
lancesix
left a comment
lancesix
left a comment
Collaborator
There was a problem hiding this comment.
Should work as well. Thanks for the simplification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.