testsuite: rocm.exp: Limit wave output logged by info_threads_get_wave_count - #299
Open
akondrat-amd wants to merge 1 commit into
Open
testsuite: rocm.exp: Limit wave output logged by info_threads_get_wave_count#299akondrat-amd wants to merge 1 commit into
akondrat-amd wants to merge 1 commit into
Conversation
Collaborator
|
What problem exactly are we trying to solve? A timeout? A expect buffer overflow? |
Contributor
Author
We count waves at least three times in a couple of tests, it adds thousands of lines to the log, particularly, 3 x 16,384. It's a nightmare to scroll through it. |
Collaborator
|
Honestly I think we need a command to give us the number of waves we have. It is not feasible to count waves by going through a wall of text. For instance, if we run this with check-read1, it will be very slow. |
akondrat-amd
force-pushed
the
users/akondrat/info_threads_get_wave_count
branch
from
August 21, 2026 14:15
7fe6840 to
d6fee8a
Compare
…e_count On GPUs with many wavefronts, info_threads_get_wave_count floods the log with thousands of lines. Print only the first and last 20 wave lines, replacing the omitted middle with a single summary line "... N waves omitted ...".
akondrat-amd
force-pushed
the
users/akondrat/info_threads_get_wave_count
branch
from
August 21, 2026 14:46
d6fee8a to
3659584
Compare
akondrat-amd
commented
Aug 21, 2026
| proc info_threads_get_wave_count { inf_num } { | ||
| set wave_count 0 | ||
| set wave_lines {} | ||
| set test_name "unknown" |
Contributor
Author
There was a problem hiding this comment.
I use this variable to store the name of the test in order to print "pass" after we print the "wave_lines".
Contributor
Author
|
This is how the output looks: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GPUs with many wavefronts, info_threads_get_wave_count floods the log with thousands of lines. Print only the first and last 20 wave lines, replacing the omitted middle with a single summary line "... N waves omitted ...".
Key changes: