github: schedule therock deps update to run weekly on Mondays - #292
Open
lumachad wants to merge 1 commit into
Open
github: schedule therock deps update to run weekly on Mondays#292lumachad wants to merge 1 commit into
lumachad wants to merge 1 commit into
Conversation
lancesix
reviewed
Aug 20, 2026
| - name: Update TheRock references | ||
| run: | | ||
| python3 .github/scripts/update_therock_deps.py ${{ inputs.dry_run && '--dry-run' || '' }} | ||
| python3 .github/scripts/update_therock_deps.py ${{ github.event_name == 'workflow_dispatch' && inputs.dry_run && '--dry-run' || '' }} |
Collaborator
There was a problem hiding this comment.
shouldn't this be ( github.event_name == 'workflow_dispatch' || inputs.dry_run) && '--dry-run'`?
i.e. use --dry-run if either dry_run is part of the inputs, or if dealing with workfloaw_dispatch?
Collaborator
Author
There was a problem hiding this comment.
I don't think so. With your suggestion I think we'd have something like this:
- Manual dispatch + dry_run=false → (true || false) && '--dry-run' = --dry-run gets passed, which is wrong.
Collaborator
There was a problem hiding this comment.
indeed. But it feels odd to have the event type override the parameter.
Collaborator
Author
There was a problem hiding this comment.
Feels odd but acceptable or feels odd and you want it changed? :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
therock-deps-update.yml, set to run every Monday at 03:17 UTC.--dry-runflag explicitly onworkflow_dispatchso scheduled runs always execute for real.Test plan
dry_run: trueto confirm the dry-run path still works.dry_run: falseto confirm the real-run path works.