Repository navigation
fix: resolve code-scanning security findings - #122
Merged
Merged
Conversation
cgoea
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We triaged the GitHub code-scanning alerts on
ROCm/Quartz(zizmor, CodeQL,and Bandit) and resolved the actionable ones. This clears 6 of the 8 open
alerts and silences the ~857 Bandit
B101findings at their source. The tworemaining open alerts are left intentionally and explained below.
This PR updates the action
notify_quartzto version v1.1.3.Changes
GitHub Actions checkouts (zizmor
artipacked)We set
persist-credentials: falseon the read-only checkouts so the job tokenis no longer written to
.git/configand left in the workspace after checkout:.github/workflows/unit_tests.yml.github/workflows/pre_commit.yml.github/workflows/bender.yml.github/actions/notify_quartz/action.ymlAll four are read-only (clone/fetch, no push), so dropping the persisted
credential has no behavioral effect.
bender.ymlruns a post-checkoutgit fetch origin main develop; since the repository is public, that fetch isanonymous and continues to work.
Code injection warning (CodeQL)
In
notify_quartz/action.ymlwe moved therunner.osinterpreter selectionout of the inline
run:expression into an intermediatePYTHONenvironmentvariable, following GitHub's recommended pattern. The resolved command is
unchanged.
Dependabot cooldown (zizmor
dependabot-cooldown)We added a 7-day
cooldownto.github/dependabot.ymlso a freshly-published(and possibly compromised or yanked) action version has time to settle before
a bump PR is opened.
Bandit B101 noise
We added an
assert_used.skipsblock tobandit.ymlscoped to*/tests/*and*_test.py.assertis pytest's assertion mechanism, soB101is pure noisein test files; the skip silences it there while keeping
B101active forproduction code, where asserts are stripped under
python -Oand must not beused as runtime guards. Verified locally: the test tree drops from 958
B101findings to 0, while a production assert still flags.
Changelog
Bumped the
notify_quartzaction to v1.1.3 indocs/changelogs/notify_quartz.md(security hardening, no interface orbehavior change).
Left intentionally
Two
artipackedalerts remain open on the push-capable checkouts:.github/workflows/receive_therock_data.yml.github/workflows/sync_develop_to_main.ymlThese check out with a GitHub App token and rely on the persisted credential to
push back to
main/develop. The credential is scoped and under our control,so we keep it rather than rewire push auth. These should be dismissed in the
code-scanning UI as intentional.
Follow-up
After merge, tag the action release on
main: createnotify_quartz/v1.1.3and move
notify_quartz/v1to the same commit.Test plan
pre-commit run --filespasses on all changed files (actionlint,mdformat, YAML checks) -- confirmed locally
B101on the test tree withbandit.ymlunit_tests,pre-commit, andbenderworkflows pass on this PR