Conversation
* Add Cohere Command R7B and Command A+ to vLLM extended suite Also bump the pyt_vllm base image to vllm/vllm-openai-rocm:v0.28.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015S3frHBxF3j5AsWL6gt3dk * Drop comments and keep vision tower for Cohere extended configs Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015S3frHBxF3j5AsWL6gt3dk --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
i-kosarev
requested review from
Cemberk,
amathews-amd,
coketaste,
gargrahul,
itej89,
lcskrishna and
leconcio
as code owners
September 14, 2026 22:00
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The extended configurations use environment mappings that prevent the vLLM server from starting.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Cohere Command R7B and Command A+ to the vLLM extended suite and updates the ROCm image to v0.28.0.
Changes:
- Registers both Cohere models and benchmark configurations.
- Updates the vLLM Docker image and documentation.
- Adds release-note coverage.
File summaries
| File | Summary |
|---|---|
scripts/vllm/models.json |
Registers the Cohere workloads. |
scripts/vllm/configs/extended.yaml |
Adds serving configurations; environment mappings at lines 92 and 103 produce invalid shell syntax. |
docker/pyt_vllm.ubuntu.amd.Dockerfile |
Updates the vLLM base image to v0.28.0. |
benchmark/vllm/README.md |
Updates benchmark documentation and model listings. |
Review details
Suppressed comments (1)
scripts/vllm/configs/extended.yaml:104
envis parsed as a mapping here, butrun_vllm.pyinterpolates this value directly into the shell command (f"{env} ..."), producing{'VLLM_ROCM_USE_AITER': 1} vllm serve ..., which is not a valid environment assignment and prevents the server from starting. Render the mapping asKEY=VALUEassignments in the runner, or use the string form accepted by the current runner for this entry.
env:
VLLM_ROCM_USE_AITER: 1
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+92
to
+93
| env: | ||
| VLLM_ROCM_USE_AITER: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bump the pyt_vllm base image to vllm/vllm-openai-rocm:v0.28.0.
Claude-Session: https://claude.ai/code/session_015S3frHBxF3j5AsWL6gt3dk
Claude-Session: https://claude.ai/code/session_015S3frHBxF3j5AsWL6gt3dk
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist