Proto data dependent symbolics#5077
Draft
CharlieL7 wants to merge 3 commits into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return inputs.at(0); | ||
| } | ||
|
|
||
| //TODO: have a function that tells how to link up the symbols to the inputs? Or keep it a simple 1 to 1? |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| //TODO: have a function that tells how to link up the symbols to the inputs? Or keep it a simple 1 to 1? | |
| // TODO: have a function that tells how to link up the symbols to the inputs? Or keep it a | |
| // simple 1 to 1? |
Comment on lines
+70
to
+73
| argument compute(shape, std::vector<argument> args) const | ||
| { | ||
| return args[0]; | ||
| } |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| argument compute(shape, std::vector<argument> args) const | |
| { | |
| return args[0]; | |
| } | |
| argument compute(shape, std::vector<argument> args) const { return args[0]; } |
| * slice(input, ends, axes); starts set | ||
| * slice(input, start, ends, axes); none set | ||
| * `mode` specifies what the inputs to slice are: | ||
| * one_input: slice(input); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| * one_input: slice(input); | |
| * one_input: slice(input); |
Comment on lines
+69
to
+79
| MIGRAPHX_NESTED_ENUM_CLASS( | ||
| slice_mode, | ||
| one_input, | ||
| starts_input, | ||
| ends_input, | ||
| axes_input, | ||
| starts_ends_input, | ||
| starts_axes_input, | ||
| ends_axes_input, | ||
| starts_ends_axes_input | ||
| ); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| MIGRAPHX_NESTED_ENUM_CLASS( | |
| slice_mode, | |
| one_input, | |
| starts_input, | |
| ends_input, | |
| axes_input, | |
| starts_ends_input, | |
| starts_axes_input, | |
| ends_axes_input, | |
| starts_ends_axes_input | |
| ); | |
| MIGRAPHX_NESTED_ENUM_CLASS(slice_mode, | |
| one_input, | |
| starts_input, | |
| ends_input, | |
| axes_input, | |
| starts_ends_input, | |
| starts_axes_input, | |
| ends_axes_input, | |
| starts_ends_axes_input); |
| static auto reflect(Self& self, F f) | ||
| { | ||
| return pack(f(self.axes, "axes"), f(self.starts, "starts"), f(self.ends, "ends")); | ||
| return pack(f(self.axes, "axes"), f(self.starts, "starts"), f(self.ends, "ends"), f(self.mode, "mode")); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| return pack(f(self.axes, "axes"), f(self.starts, "starts"), f(self.ends, "ends"), f(self.mode, "mode")); | |
| return pack(f(self.axes, "axes"), | |
| f(self.starts, "starts"), | |
| f(self.ends, "ends"), | |
| f(self.mode, "mode")); |
Comment on lines
+50
to
+57
| auto ret = mm->add_instruction( | ||
| migraphx::make_op("slice", | ||
| {{"axes", {0}}, | ||
| {"starts", {0}}, | ||
| {"ends", {migraphx::to_value(num_selected_var)}}, | ||
| {"mode", "ends_input"}}), | ||
| idx, | ||
| bind); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| auto ret = mm->add_instruction( | |
| migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); | |
| auto ret = | |
| mm->add_instruction(migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); |
Comment on lines
+49
to
+56
| auto ret = mm->add_instruction( | ||
| migraphx::make_op("slice", | ||
| {{"axes", {0}}, | ||
| {"starts", {0}}, | ||
| {"ends", {migraphx::to_value(num_selected_var)}}, | ||
| {"mode", "ends_input"}}), | ||
| idx, | ||
| bind); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| auto ret = mm->add_instruction( | |
| migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); | |
| auto ret = | |
| mm->add_instruction(migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); |
Comment on lines
+49
to
+56
| auto ret = mm->add_instruction( | ||
| migraphx::make_op("slice", | ||
| {{"axes", {0}}, | ||
| {"starts", {0}}, | ||
| {"ends", {migraphx::to_value(num_selected_var)}}, | ||
| {"mode", "ends_input"}}), | ||
| idx, | ||
| bind); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| auto ret = mm->add_instruction( | |
| migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); | |
| auto ret = | |
| mm->add_instruction(migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); |
Comment on lines
+55
to
+62
| auto ret = mm->add_instruction( | ||
| migraphx::make_op("slice", | ||
| {{"axes", {0}}, | ||
| {"starts", {0}}, | ||
| {"ends", {migraphx::to_value(num_selected_var)}}, | ||
| {"mode", "ends_input"}}), | ||
| idx, | ||
| bind); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| auto ret = mm->add_instruction( | |
| migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); | |
| auto ret = | |
| mm->add_instruction(migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); |
Comment on lines
46
to
+53
| return mm->add_instruction( | ||
| migraphx::make_op("slice", {{"axes", {0}}, {"starts", {0}}}), idx, cnt); | ||
| migraphx::make_op("slice", | ||
| {{"axes", {0}}, | ||
| {"starts", {0}}, | ||
| {"ends", {migraphx::to_value(num_selected_var)}}, | ||
| {"mode", "ends_input"}}), | ||
| idx, | ||
| bind); |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| return mm->add_instruction( | |
| migraphx::make_op("slice", {{"axes", {0}}, {"starts", {0}}}), idx, cnt); | |
| migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); | |
| return mm->add_instruction(migraphx::make_op("slice", | |
| {{"axes", {0}}, | |
| {"starts", {0}}, | |
| {"ends", {migraphx::to_value(num_selected_var)}}, | |
| {"mode", "ends_input"}}), | |
| idx, | |
| bind); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.