Implement a proper unit test for RectUtil and make it actually work right.#166
Merged
Conversation
NicEastvillage
approved these changes
Jun 3, 2026
Contributor
Author
|
Sorry, forgot to change test names, so decided to do that as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I said:
Given that I've already implemented a unit test, you'd think it'd have crossed my mind to implement another one to actually test this properly. Alas, it didn't, so I only did that now.
It turned out that I was wrong - the lookup table actually failed to accurately produce many rectangles (even below 1000px range). So I made
ApproximateRectjust calculate the exact solution instead. Out of curiosity, I tried to not even use the lookup table as a backup strategy. It turns out that all rectangles from 1×1 up to 7680×7680 (and probably beyond) do have an exact solution (forRendering.FontWidthPixelsandRendering.FontHeightPixels) that fits in the 30000 string length limit.So I just dropped the lookup table entirely and renamed
ApproximateRecttoRectSolve.To my credit, I did optimize the GCD function. So at least we've got that from this whole adventure. 👍