Skip to content

fix(channels): silence httpx request logging so bot tokens stay out of logs #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chongjiazhen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(channels): silence httpx request logging so bot tokens stay out of logs #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions services/channel_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
level=logging.INFO,
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",
)
# python-telegram-bot issues its API calls through httpx, and the bot token
# is part of the request URL. httpx logs a line per request at INFO, so
# leaving it enabled writes the token to the logs in plaintext.
logging.getLogger("httpx").setLevel(logging.WARNING)
logging.getLogger("httpcore").setLevel(logging.WARNING)
logger = logging.getLogger("channel_worker")

CHANNEL_CONFIG_POLL_INTERVAL_S = float(
Expand Down
5 changes: 5 additions & 0 deletions services/worker_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@
level=logging.INFO,
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",
)
# python-telegram-bot issues its API calls through httpx, and the bot token
# is part of the request URL. httpx logs a line per request at INFO, so
# leaving it enabled writes the token to the logs in plaintext.
logging.getLogger("httpx").setLevel(logging.WARNING)
logging.getLogger("httpcore").setLevel(logging.WARNING)
logger = logging.getLogger("heartbeat_worker")

POLL_INTERVAL = float(os.getenv("WORKER_POLL_INTERVAL", 1.0))
Expand Down
Loading