Skip to content

feat: Datastore keys and error messages #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quenty wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Datastore keys and error messages #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/adorneedata/src/Shared/AdorneeDataValue.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function AdorneeDataValue:__newindex(index, newValue)
if attributeValues[key] then
attributeValues[key].Value = value
else
error("%s is not a valid member of AttributeValue")
error(string.format("%s is not a valid member of AttributeValue", key))
end
end
else
Expand Down
12 changes: 10 additions & 2 deletions src/datastore/src/Server/GameDataStoreService.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export type GameDataStoreService = typeof(setmetatable(
_dataStorePromise: Promise.Promise<DataStore.DataStore>?,
_robloxDataStorePromise: Promise.Promise<any>?,
_bindToCloseService: any,
_key: string?,
},
{} :: typeof({ __index = GameDataStoreService })
))
Expand Down Expand Up @@ -81,8 +82,15 @@ function GameDataStoreService._promiseRobloxDataStore(self: GameDataStoreService
return self._robloxDataStorePromise
end

function GameDataStoreService._getKey(_self: GameDataStoreService): string
return "version1"
function GameDataStoreService.SetDataStoreKey(self: GameDataStoreService, key: string): ()
assert(type(key) == "string", "Bad key")
assert(not self._dataStorePromise, "Cannot set key after datastore has been promised")

self._key = key
end

function GameDataStoreService._getKey(self: GameDataStoreService): string
return self._key or "version1"
end

function GameDataStoreService.Destroy(self: GameDataStoreService)
Expand Down
Loading