Repository navigation
fuse_charge for adding charges to operators - #60
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
Definitely looks reasonable to me, maybe we can just brainstorm slightly about the name? |
|
First I deliberately avoided To make hybrids, |
lkdvos
left a comment
There was a problem hiding this comment.
Just getting some opinions here, I have a slight preference to avoid add and use fuse to stick a bit more to the categorical language, especially since adding really only makes sense in our particular parametrization of ZNIrrep or U1Irrep. shift also seems like a good candidate, since that is typically the purpose? In principle I'm also okay with migrating the MPSKit function here and then simply overloading it in MPSKit, but I do agree that is a bit more annoying to orchestrate.
|
@lkdvos How about you listing a few options and then we vote by emoji reactions? I now prefer |
|
I like |
add_charge for adding charges to operatorsfuse_charge for adding charges to operators
This PR exports one more utility function
fuse_chargeto add charges to operators.(It can replace
_fuse_idscurrently in PEPSKit.)