Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
I'm not sure what's the best way to check invalid fusion channels. I first separated it completely from the shape of Fsymbol test, but then put it back in since I kind of want to check the four fusion vertices of a potentially valid F-move. |
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Overall definitely looks good! I think there are some slight improvements that can still be made with the loop order to avoid double-checking things, but otherwise this seems good to go
| for f in smallset(I) | ||
| can_fuse(a, f) || @test_throws ArgumentError Nsymbol(a, f, r) | ||
| end |
There was a problem hiding this comment.
this loop does not depend on c or b so is needlessly repeated quite often. Additionally, since smallset is deterministic (I think?), all of these tests are permutations of the same set of tests, so probably this can be simplified quite a bit.
|
There's no cleaner way to avoiding double checks than just separating them I believe, so I ended up going back to that |
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2 participants
Tackles #60. As left as comment, CategoryData stores the
GenericFusiontopological data as sparse arrays, so this will fail. Not sure if it's sufficient to just check whether everything's a subtype ofAbstractArray{T, N}?I also had some fusion ring checks lying around and decided to add them. It might be overkill, since it'll be a bunch of
0=0or1=1equations 🫠