Skip to content

test GenericUnit property is reserved for multifusion - #109

Merged
borisdevos merged 1 commit into
mainfrom
bd-genericunit
Sep 8, 2026
Merged

borisdevos merged 1 commit into
mainfrom
bd-genericunit

Conversation

@borisdevos

Copy link
Copy Markdown
Member

Even though fusion categories are technically multifusion, UnitStyle is reserved really to have to account for colorings. Things are simplified if the single-color property of fusion categories is enforced.

@borisdevos borisdevos changed the title test GenericUnit property only reserved for multifusion test GenericUnit property is reserved for multifusion Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I can only come up with one counterexample where we might not want this, which is to generate a minimal testcase that exercises the interface, similar to how PlanarTrivial says it can't braid even though of course that is not really true. If this is not really something we'd want, feel free to merge.

@Jutho

Jutho commented Sep 8, 2026

Copy link
Copy Markdown
Member

I am fine testing that this is set correctly for the sectors we provide, but I would not enforce this as a rule indeed. From that perspective, I think my comment here ( QuantumKitHub/TensorKit.jl#515 (comment) ) still applies.

@borisdevos

Copy link
Copy Markdown
Member Author

Okay I'll merge, add the additional check in that TK PR, and we can revisit this test if we ever decide to implement GenericIsingAnyon or something like that to compare to IsingBimodule :)

@borisdevos
borisdevos merged commit 073d7b3 into main Sep 8, 2026
12 checks passed
@borisdevos
borisdevos deleted the bd-genericunit branch September 8, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants