Skip to content

fix: have LargeZNIrrep actually have unknown size of sector values - #108

Merged
lkdvos merged 1 commit into
mainfrom
bd/znirrep
Aug 7, 2026
Merged

lkdvos merged 1 commit into
mainfrom
bd/znirrep

Conversation

@borisdevos

Copy link
Copy Markdown
Member

LargeZNIrrep wasn't actually avoiding the NTuple storage method in graded spaces. Tracked it down to some annoying Julia dispatch.

Before:

julia> I = ZNIrrep{200};

julia> II = LargeZNIrrep{200};

julia> Vect[I]
ZNSpace{200} (alias for GradedSpace{ZNIrrep{200}, NTuple{200, Int64}})

julia> Vect[II]
GradedSpace{LargeZNIrrep{200}, NTuple{200, Int64}}

After:

julia> Vect[II]
GradedSpace{LargeZNIrrep{200}, TensorKit.SortedVectorDict{LargeZNIrrep{200}, Int64}}

@codecov

codecov Bot commented Aug 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/irreps/znirrep.jl 93.54% <100.00%> (+3.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos merged commit bd1bf82 into main Aug 7, 2026
12 checks passed
@lkdvos
lkdvos deleted the bd/znirrep branch August 7, 2026 16:34
@lkdvos lkdvos mentioned this pull request Oct 1, 2026
lkdvos referenced this pull request Oct 1, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants