Skip to content

update VectorInterface compat to add v0.7 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lkdvos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update VectorInterface compat to add v0.7 #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,5 @@ TensorKitSectors = "0.3.7"
TensorOperations = "5.5.2, 5.6"
TimerOutputs = "1"
TupleTools = "1.5"
VectorInterface = "0.6"
VectorInterface = "0.6, 0.7"
julia = "1.10"
2 changes: 2 additions & 0 deletions docs/src/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ When releasing a new version, move the "Unreleased" changes to a new version sec

### Changed

- Extend VectorInterface compat to include v0.7

### Deprecated

### Removed
Expand Down
10 changes: 6 additions & 4 deletions src/tensors/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,13 @@ function LinearAlgebra.tr(t::AbstractTensorMap)
return s
end

# LinearAlgebra's BLAS wrappers do not accept `VectorInterface.One`/`Zero`, e.g.
# `herk_wrapper!` (hit by `mul!(C, A, A')`) calls `isreal` on the scalars.
# LinearAlgebra's BLAS wrappers do not accept `VectorInterface.One`/`Zero` before
# VectorInterface v0.7, e.g. `herk_wrapper!` (hit by `mul!(C, A, A')`) calls `isreal`.
_blasscalar(α::Number) = α
_blasscalar(::One) = true
_blasscalar(::Zero) = false
@static if !(One <: Real)
_blasscalar(::One) = true
_blasscalar(::Zero) = false
end

# TensorMap multiplication
function LinearAlgebra.mul!(
Expand Down
Loading