Skip to content

Restore custom rule for twist to calm 1.10 - #559

Merged
kshyatt merged 3 commits into
mainfrom
ksh/restore_twist
Sep 30, 2026
Merged

kshyatt merged 3 commits into
mainfrom
ksh/restore_twist

Conversation

@kshyatt

@kshyatt kshyatt commented Sep 29, 2026

Copy link
Copy Markdown
Member

Enzyme's attempt to roll its own rule is leading to the CI segfaults. We can remove this once support for 1.10 is dropped.

@kshyatt
kshyatt requested a review from lkdvos September 29, 2026 15:19

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I somehow thought we already had a rule for that, but if this fixes the CI failures I'd be incredibly happy!

@kshyatt

kshyatt commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

We had one and I removed it thinking Enzyme would succeed in making its own... and it did, on 1.12 only

@kshyatt

kshyatt commented Sep 30, 2026 •

Copy link
Copy Markdown
Member Author

permute was dying due to an Enzyme bug. If the linalg and vo ones fail I'll open a new PR to work on them separately. Unfortunately we will need the custom rule for twist! also on the new Enzyme version. I'm working on fixing the underlying issue.

@kshyatt

kshyatt commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

OK this fixes the 1.10 failures, I'll see if I can't make the norm ones happy too. I also created a PR at Enzyme to use some of these as an integration test so hopefully this stops breaking so much.

@kshyatt

kshyatt commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

The norm ones need further fixes at Enzyme, sadly.

@kshyatt
kshyatt merged commit e288a38 into main Sep 30, 2026
74 of 79 checks passed
@kshyatt
kshyatt deleted the ksh/restore_twist branch September 30, 2026 15:34
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ext/TensorKitEnzymeExt/indexmanipulations.jl 72.22% 5 Missing ⚠️
Files with missing lines Coverage Δ
ext/TensorKitEnzymeExt/indexmanipulations.jl 82.41% <72.22%> (-6.63%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants