Skip to content

Precompile planar contraction/trace paths for non-symmetric braiding - #557

Merged
lkdvos merged 1 commit into
mainfrom
precompile
Sep 28, 2026
Merged

lkdvos merged 1 commit into
mainfrom
precompile

Conversation

@lkdvos

@lkdvos lkdvos commented Sep 25, 2026

Copy link
Copy Markdown
Member

Summary

  • precompile_contract used tensorcontract!/tensortrace!/@tensor, which only support SymmetricBraiding, so precompilation errored for anyonic/no-braiding sectortypes
  • always run the planar counterparts (planarcontract!, planartrace!, @plansor), and only additionally run the non-planar ones when BraidingStyle is symmetric
  • apply the same guard in precompile_indexmanipulations for permute/braid, and add AdjointTensorMap coverage

Test plan

  • verified precompile_contract/precompile_indexmanipulations/precompile_factorizations succeed for Bosonic, Fermionic, Anyonic, and NoBraiding sectortypes

🤖 Generated with Claude Code

@lkdvos
lkdvos requested a review from Jutho September 26, 2026 13:00
@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/precompile/indexmanipulations.jl 66.66% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/precompile/contract.jl 100.00% <100.00%> (ø)
src/precompile/precompile.jl 86.95% <ø> (ø)
src/precompile/indexmanipulations.jl 88.46% <66.66%> (-11.54%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos requested a review from kshyatt September 28, 2026 17:05
@lkdvos
lkdvos merged commit 81a7a80 into main Sep 28, 2026
65 of 67 checks passed
@lkdvos
lkdvos deleted the precompile branch September 28, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants