Fix a bug in the eig pushfwd and enable more tests - #290
Merged
Merged
Conversation
Jutho
reviewed
Oct 1, 2026
Comment on lines
13
to
20
| ∂K .*= inv_safe.(transpose(diagview(D)) .- diagview(D), degeneracy_atol) | ||
| mul!(ΔV, V, ∂K) | ||
| ΔV .-= V .* real.(sum(conj.(V) .* ΔV; dims = 1)) | ||
| if eltype(V) <: Complex # fix gauge for `gaugefix!` compatibility | ||
| _, I = findmax(abs, V; dims = 1) | ||
| infinitesimal_phases = imag.(ΔV[I] ./ V[I]) | ||
| ΔV .-= im .* V .* infinitesimal_phases | ||
| end |
Member
There was a problem hiding this comment.
Suggested change
| ∂K .*= inv_safe.(transpose(diagview(D)) .- diagview(D), degeneracy_atol) | |
| diagview(∂K) .-= real.(sum(conj.(V) .* ΔV; dims = 1)) | |
| if eltype(V) <: Complex # fix gauge for `gaugefix!` compatibility | |
| _, I = findmax(abs, V; dims = 1) | |
| diagview(∂K) .-= im .* imag.(ΔV[I] ./ V[I]) | |
| end | |
| mul!(ΔV, V, ∂K) |
Member
There was a problem hiding this comment.
Github didn't want to turn this into a proper suggestion, but anyway.
Member
Author
There was a problem hiding this comment.
Probably because I was too quick on the draw and merged it already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LAPACK general eigensolver forces the columns of
Vto have unit norm and my pushforward wasn't respecting this rule. Oops! Now the part ofΔVthat would change the length of the tangent is removed, and we can enable a lot more tests :)