Conversation
kshyatt
added this pull request to stack #285
September 29, 2026 12:38
Jutho
reviewed
Sep 30, 2026
kshyatt
force-pushed
the
ksh/gesvdx-rank1-guard
branch
3 times, most recently
from
October 1, 2026 16:02
c14e98a to
5d7bf12
Compare
kshyatt
removed this pull request from stack #285
October 1, 2026 21:10
kshyatt
force-pushed
the
ksh/gesvdx-rank1-guard
branch
from
October 2, 2026 05:48
5d7bf12 to
c97dfa4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I'm switching the default ROCm solver algo to
Bisectionto avoid ROCm/rocm-libraries#12188 while that is being fixed. But this revealed a new bug (😱) -- if you have a matrix that's(m, 1)or(1, n), theBisectionalgorithm returns no singular values. This differs from LAPACK which is really great. I added a """workaround""" to use Jacobi in that case, and added a special path and tests for it. This is all downstream of weird and annoying AMD behavior.