Skip to content

Allow turning off checking device factorizations to avoid blocking calls #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 6 commits into from
Sep 23, 2026
Merged

Allow turning off checking device factorizations to avoid blocking calls #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28fdf08
Allow turning off allowscalar copies for yacusolver
kshyatt Aug 17, 2026
5ac35c3
Make the checks on by default and add a docstring
Sep 17, 2026
4f99200
Missing import
Sep 17, 2026
dbf81ba
Formatter
Sep 17, 2026
68132de
Add the flags for YAROCSOLVER too
kshyatt Sep 23, 2026
d8cf28c
Add the check for gesvdx too
kshyatt Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 86 additions & 50 deletions ext/MatrixAlgebraKitAMDGPUExt/yarocsolver.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ using AMDGPU
using AMDGPU: @allowscalar
using AMDGPU.rocSOLVER
using AMDGPU.rocBLAS
using ..MatrixAlgebraKit: CHECK_LIBRARY_CALLS

# QR methods are implemented with full access to allocated arrays, so we do not need to redo this:
using AMDGPU.rocSOLVER: geqrf!, ormqr!, orgqr!
Expand All @@ -27,7 +28,8 @@ for (fname, elty, relty) in
A::StridedROCMatrix{$elty},
S::StridedROCVector{$relty} = similar(A, $relty, min(size(A)...)),
U::StridedROCMatrix{$elty} = similar(A, $elty, size(A, 1), min(size(A)...)),
Vᴴ::StridedROCMatrix{$elty} = similar(A, $elty, min(size(A)...), size(A, 2))
Vᴴ::StridedROCMatrix{$elty} = similar(A, $elty, min(size(A)...), size(A, 2));
check::Bool = CHECK_LIBRARY_CALLS[],
)
chkstride1(A, U, Vᴴ, S)
m, n = size(A)
Expand Down Expand Up @@ -85,8 +87,10 @@ for (fname, elty, relty) in
)
AMDGPU.unsafe_free!(rwork)

info = @allowscalar dev_info[1]
rocSOLVER.chkargsok(BlasInt(info))
if check
info = @allowscalar dev_info[1]
rocSOLVER.chkargsok(BlasInt(info))
end

return (S, U, Vᴴ)
end
Expand All @@ -109,6 +113,7 @@ for (fname, elty, relty) in
Vᴴ::StridedROCMatrix{$elty} = similar(A, $elty, min(size(A)...), size(A, 2));
tol::$relty = eps($relty),
max_sweeps::Int = 100,
check::Bool = CHECK_LIBRARY_CALLS[],
)
chkstride1(A, U, Vᴴ, S)
m, n = size(A)
Expand Down Expand Up @@ -165,8 +170,10 @@ for (fname, elty, relty) in
S, U, ldu, Vᴴ, ldv, dev_info,
)

info = @allowscalar dev_info[1]
rocSOLVER.chkargsok(BlasInt(info))
if check
info = @allowscalar dev_info[1]
rocSOLVER.chkargsok(BlasInt(info))
end

AMDGPU.unsafe_free!(dev_residual)
AMDGPU.unsafe_free!(dev_n_sweeps)
Expand Down Expand Up @@ -227,6 +234,7 @@ for (fname, elty, relty) in
S::StridedROCVector{$relty} = similar(A, $relty, min(size(A)...)),
U::StridedROCMatrix{$elty} = similar(A, $elty, size(A, 1), min(size(A)...)),
Vᴴ::StridedROCMatrix{$elty} = similar(A, $elty, min(size(A)...), size(A, 2));
check::Bool = CHECK_LIBRARY_CALLS[],
kwargs...
)
chkstride1(A, U, Vᴴ, S)
Expand All @@ -251,8 +259,10 @@ for (fname, elty, relty) in
S, U, ldu, Vᴴ, ldv, ifail,
dev_info
)
info = @allowscalar dev_info[1]
rocSOLVER.chkargsok(BlasInt(info))
if check
info = @allowscalar dev_info[1]
rocSOLVER.chkargsok(BlasInt(info))
end
# Zero the entries of `S` that `gesvdx` did not write.
nv = @allowscalar Int(nsv[1])
nv < length(S) && fill!(view(S, (nv + 1):length(S)), zero(eltype(S)))
Expand All @@ -275,7 +285,9 @@ end
# jobz::Char,
# uplo::Char,
# A::StridedROCMatrix{$elty},
# B::StridedROCMatrix{$elty})
# B::StridedROCMatrix{$elty};
# check::Bool = CHECK_LIBRARY_CALLS[],
# )
# chkuplo(uplo)
# nA, nB = checksquare(A, B)
# if nB != nA
Expand All @@ -298,9 +310,10 @@ end
# buffer, sizeof(buffer) ÷ sizeof($elty), dh.info)
# end

# info = @allowscalar dh.info[1]
# chkargsok(BlasInt(info))

# if check
# info = @allowscalar dh.info[1]
# chkargsok(BlasInt(info))
# end
# if jobz == 'N'
# return W
# elseif jobz == 'V'
Expand All @@ -322,7 +335,9 @@ end
# A::StridedROCMatrix{$elty},
# B::StridedROCMatrix{$elty};
# tol::$relty=eps($relty),
# max_sweeps::Int=100)
# max_sweeps::Int=100;
# check::Bool = CHECK_LIBRARY_CALLS[],
# )
# chkuplo(uplo)
# nA, nB = checksquare(A, B)
# if nB != nA
Expand All @@ -349,9 +364,10 @@ end
# return $fname(dh, itype, jobz, uplo, n, A, lda, B, ldb, W,
# buffer, sizeof(buffer) ÷ sizeof($elty), dh.info, params[])
# end

# info = @allowscalar dh.info[1]
# chkargsok(BlasInt(info))
# if check
# info = @allowscalar dh.info[1]
# chkargsok(BlasInt(info))
# end

# rocsolverDnDestroySyevjInfo(params[])

Expand All @@ -378,7 +394,9 @@ end
# uplo::Char,
# A::StridedROCArray{$elty};
# tol::$relty=eps($relty),
# max_sweeps::Int=100)
# max_sweeps::Int=100;
# check::Bool = CHECK_LIBRARY_CALLS[],
# )

# # Set up information for the solver arguments
# chkuplo(uplo)
Expand Down Expand Up @@ -409,14 +427,15 @@ end
# sizeof(buffer) ÷ sizeof($elty), dh.info, params[], batchSize)
# end

# # Copy the solver info and delete the device memory
# info = @allowscalar collect(dh.info)

# # Double check the solver's exit status
# for i in 1:batchSize
# chkargsok(BlasInt(info[i]))
# end

# if check
# # Copy the solver info and delete the device memory
# info = collect(dh.info)
#
# # Double check the solver's exit status
# for i in 1:batchSize
# chkargsok(BlasInt(info[i]))
# end
# end
# rocsolverDnDestroySyevjInfo(params[])

# # Return eigenvalues (in W) and possibly eigenvectors (in A)
Expand All @@ -436,7 +455,9 @@ end
# @eval begin
# function potrsBatched!(uplo::Char,
# A::Vector{<:StridedROCMatrix{$elty}},
# B::Vector{<:StridedROCVecOrMat{$elty}})
# B::Vector{<:StridedROCVecOrMat{$elty}};
# check::Bool = CHECK_LIBRARY_CALLS[],
# )
# if length(A) != length(B)
# throw(DimensionMismatch(""))
# end
Expand All @@ -462,11 +483,11 @@ end

# # Run the solver
# $fname(dh, uplo, n, nrhs, Aptrs, lda, Bptrs, ldb, dh.info, batchSize)

# # Copy the solver info and delete the device memory
# info = @allowscalar dh.info[1]
# chklapackerror(BlasInt(info))

# if check
# # Copy the solver info and delete the device memory
# info = @allowscalar dh.info[1]
# chklapackerror(BlasInt(info))
# end
# return B
# end
# end
Expand All @@ -477,7 +498,7 @@ end
# (:rocsolverDnCpotrfBatched, :ComplexF32),
# (:rocsolverDnZpotrfBatched, :ComplexF64))
# @eval begin
# function potrfBatched!(uplo::Char, A::Vector{<:StridedROCMatrix{$elty}})
# function potrfBatched!(uplo::Char, A::Vector{<:StridedROCMatrix{$elty}}; check::Bool = CHECK_LIBRARY_CALLS[],)

# # Set up information for the solver arguments
# chkuplo(uplo)
Expand All @@ -493,14 +514,15 @@ end
# # Run the solver
# $fname(dh, uplo, n, Aptrs, lda, dh.info, batchSize)

# # Copy the solver info and delete the device memory
# info = @allowscalar collect(dh.info)
# if check
# # Copy the solver info and delete the device memory
# info = collect(dh.info)

# # Double check the solver's exit status
# for i in 1:batchSize
# chkargsok(BlasInt(info[i]))
# # Double check the solver's exit status
# for i in 1:batchSize
# chkargsok(BlasInt(info[i]))
# end
# end

# # info[i] > 0 means the leading minor of order info[i] is not positive definite
# # LinearAlgebra.LAPACK does not throw Exception here
# # to simplify calls to isposdef! and factorize
Expand All @@ -510,11 +532,13 @@ end
# end

# # gesv
# function gesv!(X::CuVecOrMat{T}, A::CuMatrix{T}, B::CuVecOrMat{T}; fallback::Bool=true,
# function gesv!(X::ROCVecOrMat{T}, A::ROCMatrix{T}, B::ROCVecOrMat{T}; fallback::Bool=true,
# residual_history::Bool=false, irs_precision::String="AUTO",
# refinement_solver::String="CLASSICAL",
# maxiters::Int=0, maxiters_inner::Int=0, tol::Float64=0.0,
# tol_inner=Float64 = 0.0) where {T<:BlasFloat}
# tol_inner=Float64 = 0.0,
# check::Bool = CHECK_LIBRARY_CALLS[],
# ) where {T<:BlasFloat}
# params = CuSolverIRSParameters()
# info = CuSolverIRSInformation()
# n = checksquare(A)
Expand Down Expand Up @@ -583,7 +607,8 @@ for (heevd, heev, heevx, heevj, elty, relty) in
A::StridedROCMatrix{$elty},
W::StridedROCVector{$relty},
V::StridedROCMatrix{$elty};
uplo::Char = 'U'
uplo::Char = 'U',
check::Bool = CHECK_LIBRARY_CALLS[],
)
chkuplo(uplo)
n = checksquare(A)
Expand All @@ -601,8 +626,10 @@ for (heevd, heev, heevx, heevj, elty, relty) in
roc_uplo = convert(rocSOLVER.rocblas_fill, uplo)
$heevd(dh, jobz, roc_uplo, n, A, lda, W, work, dev_info)

info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
if check
info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
end

if jobz == rocSOLVER.rocblas_evect_original && V !== A
copy!(V, A)
Expand All @@ -613,7 +640,8 @@ for (heevd, heev, heevx, heevj, elty, relty) in
A::StridedROCMatrix{$elty},
W::StridedROCVector{$relty},
V::StridedROCMatrix{$elty};
uplo::Char = 'U'
uplo::Char = 'U',
check::Bool = CHECK_LIBRARY_CALLS[],
)
chkuplo(uplo)
n = checksquare(A)
Expand All @@ -631,8 +659,10 @@ for (heevd, heev, heevx, heevj, elty, relty) in
roc_uplo = convert(rocSOLVER.rocblas_fill, uplo)
$heev(dh, jobz, roc_uplo, n, A, lda, W, work, dev_info)

info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
if check
info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
end

if jobz == rocSOLVER.rocblas_evect_original && V !== A
copy!(V, A)
Expand All @@ -644,6 +674,7 @@ for (heevd, heev, heevx, heevj, elty, relty) in
W::StridedROCVector{$relty},
V::StridedROCMatrix{$elty};
uplo::Char = 'U',
check::Bool = CHECK_LIBRARY_CALLS[],
kwargs...
)
chkuplo(uplo)
Expand Down Expand Up @@ -680,8 +711,10 @@ for (heevd, heev, heevx, heevj, elty, relty) in
roc_uplo = convert(rocSOLVER.rocblas_fill, uplo)
$heevx(dh, jobz, range, roc_uplo, n, A, lda, vl, vu, il, iu, abstol, nev, W, V, ldv, ifail, dev_info)

info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
if check
info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
end
m = @allowscalar nev[1]
return W, V, m
end
Expand All @@ -692,7 +725,8 @@ for (heevd, heev, heevx, heevj, elty, relty) in
uplo::Char = 'U',
tol::$relty = eps($relty),
max_sweeps::Int = 100,
sort::Char = 'N'
sort::Char = 'N',
check::Bool = CHECK_LIBRARY_CALLS[],
)
chkuplo(uplo)
n = checksquare(A)
Expand All @@ -712,8 +746,10 @@ for (heevd, heev, heevx, heevj, elty, relty) in
roc_sort = sort == 'N' ? rocSOLVER.rocblas_esort_none : rocSOLVER.rocblas_esort_ascending
$heevj(dh, roc_sort, jobz, roc_uplo, n, A, lda, tol, residual, max_sweeps, n_sweeps, W, dev_info)

info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
if check
info = @allowscalar dev_info[1]
chkargsok(BlasInt(info))
end

if jobz == rocSOLVER.rocblas_evect_original && V !== A
copy!(V, A)
Expand Down
Loading
Loading