Conversation
…n sites left_canonicalize!/right_canonicalize! forced both virtual legs of the reconstructed A-block empty in the "fully truncated" (dim(R)==0) branch, but only the leg actually being decomposed collapses when a bond only partially decouples. Inherit the other leg's real space instead. Fixes #522 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
BlockTensorKit 0.3.17/0.3.18 silently returned zero from sparse block-tensor contractions with 3+ legs, corrupting convert(TensorMap, ::FiniteMPOHamiltonian) and related densification paths for essentially any Hamiltonian. 0.3.19 fixes this upstream; tests (operators/mpohamiltonian, algorithms/changebonds) pass cleanly against it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522
left_canonicalize!/right_canonicalize!forced both virtual legs ofthe reconstructed
A-block empty in the "fully truncated" branch, butonly the leg actually being decomposed collapses when a bond only
partially decouples. Inherit the other leg's real space instead.
Also bumps the
BlockTensorKitcompat bound to 0.3.19, which fixes anunrelated upstream bug where sparse block-tensor contractions with 3+
legs silently returned zero.
Test plan
test/operators/mpohamiltonian.jl(new regression testset + full file): 229/229 passtest/algorithms/changebonds.jl: 68/68 pass🤖 Generated with Claude Code