[jkhav]

Closes #84 (F30, F71, F77) and #82 (F26, F59–F63). Part of #87 (F65; F41 is in #94).

Second of a stack of four. Stacked on #96, so review only the top commit.

Bugs:

• cli/simulator.py (cli/simulator.py crashes or prints wrong values #84):
  • F30: simulate_matrix looked gates up as Matrix methods, which exist only for some gates. 15 of the 26 gates, id and measure crashed.
  • F71: -m/--meas accepted any integer and silently gave an all-zero post-measurement state.
  • F77: -v matrix -c FiveTuple printed the matrix without its 1/√2^k scale.
• Number classes (Number classes lose k or mutate their operands #82):
  • F26, F59: the generator-less Matrix constructor set k = 0, so transpose, dagger, + and - lost k. density_from_vector dropped it too (|+⟩⟨+| became all ones).
  • F60: scalar multiplication crashed for FiveTuple and changed its operand; conjugate() changed it in place.
  • F61: Vector.copy dropped name, bound and n.
  • F62: Complex / Complex returned None; FiveTuple / int raised.
  • F63: Vector.__eq__ compared k syntactically, so the same state with another k was unequal.
• Simulator stats (Reported timings and simulator stats are wrong #87 F65): the stats accumulated over repeated parse_file calls, and measured_qubits had one copy of each qubit per input vector. After refactor: replace Logger with logging module and fix timings (#86, #87 F41) #94 is merged, closes Reported timings and simulator stats are wrong #87.

Fix:

• simulate_matrix builds the matrix from the simulated images of the basis states, so every gate works, and it rejects circuits with measurements (they have no unitary). The matrix keeps k, and its repr shows it.
• The measurement outcome can be only 0 or 1: argparse choices, Simulator, and Vector.measure.
• Matrix:
  • the constructor keeps the given k;
  • density_from_vector scales a FiveTuple result by 2k;
  • + and - raise for FiveTuple operands with different k;
  • scalar operations and conjugate() return a new matrix, and a FiveTuple matrix takes only integer scalars.
• Vector.copy copies the object and its elements; FiveTuple vectors compare by value (rescale_with). Complex / Complex is implemented, and FiveTuple / int works.
• Simulator.reset_stats() runs on every parse. measured_qubits holds each qubit once, in the order of its first measurement, and nothing with no_measurement.

Tests: 95 new, in test_matrix.py, test_simulator.py and test_small_fixes.py:

• simulate_matrix checked against Qiskit for every gate, operand order and both representations;
• the CLI prints k and rejects other outcomes;
• matrix scalar operations and k handling;
• repeated simulations, and unique measured qubits;
• Vector.copy, value equality, division.

The full suite passes locally on this branch (579 tests).

[codecov]

Codecov Report

❌ Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/complex/fivetuple.py	0.0%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!