Repository navigation
Don't register SMTInterpol for QF_NRA - #100
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
SMTInterpol answers unknown to any nonlinear term, even x*y = 1 with x = 2, but it was registered for QF_NRA. A Classic synthesis with -a smtinterpol therefore never found a circuit and kept deepening, and the pySMT NRA portfolio included a solver that cannot answer. SMTInterpol is registered for QF_LIA and QF_NIA only, and it is no longer in the pySMT NRA portfolio. A solver that does not support the logic of the chosen representation is rejected up front with "<solver> does not support <logic>"; without the check, dropping the registration would turn the endless search into a KeyError. The same check covers opensmt with Classic, which raised KeyError: 'opensmt'. The solver table in docs/usage.md no longer lists SMTInterpol for Classic.
ondrik
force-pushed
the
fix/smtinterpol-nra
branch
from
October 26, 2026 23:16
e6337f2 to
534753f
Compare
ondrik
approved these changes
Oct 27, 2026
ondrik
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: SMTInterpol is registered for QF_NRA, but it answers
unknownto any nonlinear term, evenx*y = 1withx = 2.-a smtinterpolnever finds a circuit and keeps deepening.-c Classic,-a opensmt(not registered for QF_NRA) crashes withKeyError: 'opensmt'.Fix:
synthesis()rejects a solver that does not support the logic of the chosen representation, withValueError: <solver> does not support <logic>. Without this check, dropping the registration alone would turn the endless search into aKeyError.docs/usage.mdno longer lists SMTInterpol for Classic.Tests:
test_solver_without_nra_is_rejected_for_classic, for smtinterpol and opensmt.master'ssynth.py: the opensmt case fails withKeyError: 'opensmt', and the smtinterpol case is still searching when a 90 s timeout stops it.There is no issue for this; it was found while triaging the solver registrations.