Repository navigation
[CRASHFIX] Fix DisCoCirc crash when first sentence has no nouns - #262
Open
unprovable wants to merge 1 commit into
Open
unprovable wants to merge 1 commit into
unprovable wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text2circuitcrashes with "ValueError: max() arg is an empty sequence" when a sentence has no surviving nouns and no wires exist yet, e.g. a first sentence whose nouns were all pruned, or one with no nouns at all. Such a sentence produces an empty diagram, so changed behaviour to skip it instead.Add a test checking that pruning every noun of the first sentence gives the same circuit as the remaining text alone, in frame and sandwich mode. It is commented out for now, as it should wait until PR #261 merges, as it utilizes the
_transitive_treetest helper present there.