Fixing Azure DevOps integration (broken because organizationName never reached createWorkItem()) - #327
Closed
jeroenterheerdt wants to merge 7 commits into
Closed
Fixing Azure DevOps integration (broken because organizationName never reached createWorkItem())#327jeroenterheerdt wants to merge 7 commits into
jeroenterheerdt wants to merge 7 commits into
Conversation
|
Jeroen ter Heerdt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
getIntegrationTargets() only passed {accessToken, rootUrl} into each
hook's config, dropping integration-specific fields stored in
integrations.config (organizationName, cloudId, teamId, etc). Azure
DevOps work item creation failed with a misleading "reconnect" auth
error because organizationName never reached createWorkItem() -
same gap affects Jira/Teams/Monday/Trello/Asana.
Also stop discarding the Azure DevOps API response body on failure,
so future errors log the actual validation message instead of a
bare status code.
Previously the Azure DevOps hook created a work item for every new post regardless of status. Switch the trigger to post.status_changed, only firing when the post moves to "Under Review". Match by status slug rather than display name, since names are admin-editable but slugs are fixed at creation - threading previousStatusSlug/newStatusSlug through the post.status_changed event payload (dispatch.ts + its three call sites) so the hook survives a future rename of the status.
…uackback createWorkItem() now adds two relations on creation: a Hyperlink back to the originating Quackback post (previously only embedded as plain text in the description, so it never showed up in the work item's Links tab), and a System.LinkTypes.Hierarchy-Reverse link to a parent work item so items aren't created unparented. The parent work item ID is a new "Parent work item ID" field in the Azure DevOps integration settings (saved to integrations.config, same mechanism as the existing project/work-item-type fields) rather than a hardcoded constant, since the right parent differs per project. Also fixes message-builders.test.ts, which still exercised Azure DevOps's old post.created contract from before it was switched to post.status_changed - it now has its own dedicated test block matching its actual event shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(integrations): forward integration config to outbound hooks
getIntegrationTargets() only passed {accessToken, rootUrl} into each hook's config, dropping integration-specific fields stored in integrations.config (organizationName, cloudId, teamId, etc). Azure DevOps work item creation failed with a misleading "reconnect" auth error because organizationName never reached createWorkItem() - same gap affects Jira/Teams/Monday/Trello/Asana.
Also stop discarding the Azure DevOps API response body on failure, so future errors log the actual validation message instead of a bare status code.