Skip to content

feat(argocd): enhance environment and service list + settings#2702

Merged
RemiBonnet merged 3 commits into
stagingfrom
feat/argo-cd-imp
May 26, 2026
Merged

feat(argocd): enhance environment and service list + settings#2702
RemiBonnet merged 3 commits into
stagingfrom
feat/argo-cd-imp

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented May 21, 2026

Summary

  • Add Service List (actions and target version)
  • Add Environment List (actions with tooltip)
  • Update ArgoCD settings with "unlink" behavior

Screenshots / Recordings

image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 67.24138% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.47%. Comparing base (0e55957) to head (1795108).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...oks/src/lib/use-local-storage/use-local-storage.ts 77.41% 5 Missing and 2 partials ⚠️
...g/use-unlink-argocd-destination-cluster-mapping.ts 0.00% 3 Missing ⚠️
...rc/lib/argocd-service-list/argocd-service-list.tsx 50.00% 0 Missing and 3 partials ⚠️
...ment-action-toolbar/environment-action-toolbar.tsx 77.77% 1 Missing and 1 partial ⚠️
...boarding/feature/src/lib/step-plans/step-plans.tsx 0.00% 2 Missing ⚠️
...argocd-integration/settings-argocd-integration.tsx 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2702      +/-   ##
===========================================
+ Coverage    45.22%   45.47%   +0.25%     
===========================================
  Files         1139     1162      +23     
  Lines        23934    24356     +422     
  Branches      6993     7130     +137     
===========================================
+ Hits         10825    11077     +252     
- Misses       11234    11349     +115     
- Partials      1875     1930      +55     
Flag Coverage Δ
unittests 45.47% <67.24%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet marked this pull request as ready for review May 21, 2026 14:47
</div>
) : null}
</div>
{manifestRevision ? (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{manifestRevision ? (
{manifestRevision && (

<Table.Cell className="flex h-full items-center border-r border-neutral">
<div className="flex min-w-0 flex-col gap-0.5 text-ssm">
{repositoryLabel ? (
{gitRepository ? (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{gitRepository ? (
{gitRepository && (

@RemiBonnet RemiBonnet enabled auto-merge (squash) May 25, 2026 14:46
@RemiBonnet RemiBonnet force-pushed the feat/argo-cd-imp branch 2 times, most recently from 1795108 to b04c68e Compare May 26, 2026 08:30
- Added tests to display warnings for redeploy and deploy actions when ArgoCD services are present.
- Updated the environment action toolbar to disable deletion for ArgoCD environments and provide appropriate tooltips.
- Introduced a new hook for unlinking ArgoCD destination cluster mappings and integrated it into the settings component.
- Refactored service list to include detailed git repository information and actions for ArgoCD services
- Updated qovery-typescript-axios to version 1.1.891 in package.json and yarn.lock.
- Refactored unlinkArgoCdDestinationClusterMapping function to accept agentClusterId and argocdClusterUrl directly.
- Updated related tests to reflect changes in the unlinking logic.
@RemiBonnet RemiBonnet merged commit d0b2f6d into staging May 26, 2026
1 check passed
@RemiBonnet RemiBonnet deleted the feat/argo-cd-imp branch May 26, 2026 11:32
@RemiBonnet
Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.309.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants