Repository navigation
fix(tests): remove ambiguity from managed execution checks - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managed E2E verification could fail when the Agent and Skill both used
sdk-proof-*names: the model confused the two resources and did not read the requested skill or memory. Use distinctsdk-agent-*andsdk-skill-*names, and supply the exact mounted file paths in the test prompt.Before session cleanup, a failed turn now logs a bounded, sanitized tail of observed public events, including tool inputs, text results and stop reasons. Add offline coverage for diagnostic redaction and capacity limits, and document how to retain the test output.
Why
Make the requested resources unambiguous while preserving the existing marker, tool-use and completion assertions. Retain useful evidence after cleanup deletes the session, without retaining reasoning blocks, binary content, authentication headers, configured PAT values or URLs.
Verification
make lintmake buildmake testmake docs-checkgo build ./examples/...Offline checks passed with Go 1.26.4 against a clean archive of the base commit plus this patch. Untracked, ignored scratch tests in the local workspace are not included in that archive.
The targeted CN Managed run, using PAT authentication and model
auto, passed all three subtests without skips: completion/SSE, file/environment, and skill/memory. Resource cleanup completed. Global and the full internal CI pipeline are not covered by this targeted run.Impact
CHANGELOG.mdunderUnreleased, or not applicable (explain below).env.live, logs, or generated test output committedThis changes Go test scaffolding and contributor guidance only. Public APIs, SDK behavior, fixtures and cleanup semantics are unchanged, so changelog entries, generated documentation and migration notes are not applicable. Python and TypeScript are outside the scope of this Go-specific failing test.