Repository navigation
Conversation
Fix issue QoderAI#195 defect 1 by probing one scoped commit beyond the analysis cap and reporting complete, capped, unknown, or skipped window coverage without treating identical hotspots as proof. The change is specified in docs/specs/2026-10-15-195-history-window-coverage.md and keeps the extra probe out of hotspot statistics. Validated with the focused real-Git regressions, the full test suite, documentation link checks, and package verification. Co-authored-by: Codex (GPT-6 Sol) <codex@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix defect 1 in #195: bounded Git history must not report unproven time-window coverage as ready.
history-window-coverageisreadyonly when every requested window has complete coverage and scoped commits were observed. Capped, unknown, skipped, or empty history requiresreview.Why
Traceability and Scope
docs/specs/2026-10-15-195-history-window-coverage.md.scripts/core-change-watch/git-history-profile.mjs,scripts/core-change-watch/evidence-pack.mjs,test/governance/core-change-watch.test.mjs, andreferences/project-harness/core-change-watch.md.Change Type
Test and Review Evidence
Checks ran on macOS using Node.js v24.21.0.
mise exec node@24.21.0 -- npx vitest run test/governance/core-change-watch.test.mjsmise exec node@24.21.0 -- npm test -- --maxWorkers=4mise exec node@24.21.0 -- npx vitest run test/skills-docs/doc-link-graph.test.mjsmise exec node@24.21.0 -- npm run pack:verifygit diff --checkManual or visual evidence: A real temporary Git repository returned
[unknown, capped, capped]andreviewwith cap=3; a complete scan returned complete coverage andready. Zero-count capped/unknown windows describe only the analyzed sample. No UI changes. Windows/Linux execution was not tested. Earlier unsuccessful full-suite attempts and their environment/timing failures are recorded in the spec; the passing full-suite result above used physical local dependencies and four workers.Risk and Recovery
ab797ffto restore the previous implementation and remove its associated tests/spec changes.AI Involvement
Checklist
AGENTS.md,CONTRIBUTING.md, and the relevant canonical-owner guidance.CHANGELOG.md. Release metadata was excluded by the accepted spec and the scope rule inAGENTS.md; this PR records the output-contract change and validation evidence.Evidence
ready; a zero-count window could imply no commits existed in unscanned history.Merge Danger
Door: two-way
Reversible as one commit. Bounded or shallow history can change an optimistic
readyresult toreview.Blast Radius: core-change-watch