fix(logging): keep file tracebacks uncolored while stderr stays colored - #156
Open
Question86 wants to merge 1 commit into
Open
fix(logging): keep file tracebacks uncolored while stderr stays colored#156Question86 wants to merge 1 commit into
Question86 wants to merge 1 commit into
Conversation
Author
|
Follow-up on design choices:\n\n- This patch intentionally handles the shared-formatter case (same Formatter instance attached to stderr + file handlers), which is where ANSI leakage commonly appears in practice.\n- It clears |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch fixes the ANSI color leak into file logs while keeping colored tracebacks on
stderr.What changed
better_exceptions/log.pyStreamHandlertargetingsys.stderr.FileHandler.record.exc_textcache per formatter call so each handler can format exceptions independently.AssertionError.argsafter formatting to avoid side effects when the same exception is formatted by multiple handlers.test/test_file_logging.pytest_all.shtest/test_file_logging.pyas an assertion-style test.Why this approach
The issue appears when multiple handlers share one formatter object and logging caches
record.exc_text. Patching a formatter globally can make file handlers inherit ANSI escapes. This patch isolates formatter behavior per handler and prevents cache cross-contamination.Closes #87